This was found when reviewing #2895388: Modules uninstall filter does not filter by machine name.

Problem/Motivation

system-modules-details.html.twig and system-modules-uninstall.html.twig add a data-striping="1" attribute to the table.

It does not actually result in the table being striped, however, as that attribute is only useful for draggable tables, but these tables are not draggable.

Proposed resolution

Remove the useless attribute.

CommentFileSizeAuthor
#5 2923305-5.patch1.02 KBsavkaviktor16@gmail.com
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tstoeckler created an issue. See original summary.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler at bio.logis Genetic Information Management GmbH commented
Issue tags: +Novice
MaskOta’s picture

MaskOta CreditAttribution: MaskOta commented

Both install and uninstall table actually contain the stripping classes. It is just the theme that chooses not to do anything with them.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler at bio.logis Genetic Information Management GmbH commented
Issue summary: View changes

Oh, you're absolutely right, totally missed that. Thanks for setting me straight! That makes this issue *super* Novice, as just the useless attributes need to be removed.

savkaviktor16@gmail.com’s picture

savkaviktor16@gmail.com CreditAttribution: savkaviktor16@gmail.com at Skilld commented
FileSize
2923305-5.patch1.02 KB

So, I've simply removed them

savkaviktor16@gmail.com’s picture

savkaviktor16@gmail.com CreditAttribution: savkaviktor16@gmail.com at Skilld commented
Status: Active » Needs review
tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler at bio.logis Genetic Information Management GmbH commented
Status: Needs review » Reviewed & tested by the community

Perfect, thanks!

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed 2d859f2 and pushed to 8.5.x. Thanks!

  • catch committed 2d859f2 on 8.5.x 
    Issue #2923305 by Saviktor, tstoeckler, MaskOta: Module (un-)install...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.