This was found reviewing #2895388: Modules uninstall filter does not filter by machine name
Our responsive table solution in core hides some columns on narrower viewports and then shows a "Show all columns" link above the table so that the hidden information is still (somewhat) accessible.
This link is missing on the module installation page.
The reason is that the JavaScript library that manages these links is not attached on these pages.
Add {{ attach_library('core/drupal.tableresponsive') }} to system-modules-details.html.twig
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | Extend___Site-Install.png | 48.14 KB | xjm |
| #6 | admin-modules-table-responsive.png | 96.08 KB | tstoeckler |
| #5 | system-2923302-5-responsive_table_on_module_install_page.patch | 712 bytes | MaskOta |
| #5 | after.png | 60.34 KB | MaskOta |
| #5 | before.png | 54.28 KB | MaskOta |
Comments
Comment #2
tstoecklerComment #3
andrewmacpherson commentedThis is only a bug on the install page. The uninstall page currently doesn't have any responsive columns, so it's not a problem there. Let's make this just about the install page. Updating title/summary. It just got even simpler as a novice task.
#2895388: Modules uninstall filter does not filter by machine name is proposing to make the uninstall page use responsive columns, in which case it's up to that issue to attach the library to the uninstall page.
Comment #4
andrewmacpherson commentedminor update, fix some linebreaks in the summary
Comment #5
MaskOta commentedI put the attachment into the buildForm function for the module list as it already contained an attached library.
Comment #6
tstoecklerLooks good to me. I thought about whether this needs a usability review, but since this is just standardizing on a well-established pattern in core, I'm going to be bold and RTBC this, even though the styling/display of the table is a bit non-standard.
This is how it looks:
Comment #8
xjmThanks @tstoeckler and @MaskOta. I tested and confirmed this small change fixes the problem.
It is a bit unwieldy because there are separate tables and so each has its own "Show all columns" link, like the below:
However, that's beyond the scope of this straightforward fix to resolve, since I believe it would require customizing the responsive tables to use a single link. We could further fix the design in followup issues if desired (both for that and for things like #6).
Committed and pushed to 8.5.x. Thanks! I didn't backport it to 8.4.x because I could imagine that there might be edgecase scenarios where it would disrupt the existing JS and/or theming.