Closed (fixed)
Project:
Rules
Version:
8.x-3.x-dev
Component:
Rules Core
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
12 Nov 2017 at 09:32 UTC
Updated:
28 Dec 2017 at 16:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
tr commentedFour more corrections ...
Comment #3
tr commentedAnd one more. Let's try the testing again ...
Comment #4
jonathan1055 commentedMinor, but still important. Thanks for doing this.
- I've done a quick google search for this and it looks like a useful thing. How did you run it? Seems like it is a node.js CLI tool, so maybe it might be worth loading and running it in the rules travis builds? I am trying to work on running ESLint in .travis.yml (no issue for that yet, but I have some work in progress in my eslint branch https://travis-ci.org/jonathan1055/rules/builds/288490761) Codespell could be added in a similar way?
Comment #5
tr commentedIt's a python script, something that came up in the core issue queue years ago. It only catches isolated words, not compound words in camelCase, which is why I amended my patch several times as I perused the codebase.
After the first pass using it and correcting errors, you rarely have to do it again - misspellings are slow to creep into the codebase.
Find it at https://github.com/lucasdemarchi/codespell
It does require python. Instructions in the README.
Comment #7
fagoThanks, pushed.