Problem/Motivation

Currently when a piece of content is moderated via the EntityModerationForm, the revision author is set to the current user, but the revision creation time is not set.

Proposed resolution

Update the revision creation time during form submit, and add a test.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 2922018-08.patch3.48 KBjhedstrom
#8 interdiff-2922018-04-08.txt2.5 KBjhedstrom
#4 2922018-04.patch1.81 KBjhedstrom
#3 2922018-03.patch1.07 KBjhedstrom

Comments

jhedstrom created an issue. See original summary.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Issue tags: +Workflow Initiative
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Active » Needs review
StatusFileSize
new 2922018-03.patch1.07 KB

This patch provides the test that makes the current behavior explicit.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
StatusFileSize
new 2922018-04.patch1.81 KB

Chatted with Tim on slack and he was thinking this wasn't intentional behavior. This patch reverses the test and updates the revision creation time.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Issue summary: View changes
amateescu’s picture

amateescu commented

The patch looks good, just a minor change needed:

+++ b/core/modules/content_moderation/src/Form/EntityModerationForm.php
@@ -132,6 +132,7 @@ public function submitForm(array &$form, FormStateInterface $form_state) {
+      $entity->setRevisionCreationTime($this->getRequest()->server->get('REQUEST_TIME'));

Let's use the time service here :)

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Status: Needs review » Needs work

Apart from #6, looks good to me.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2922018-04-08.txt2.5 KB
new 2922018-08.patch3.48 KB

The time service makes things much easier :)

amateescu’s picture

amateescu commented
Status: Needs review » Reviewed & tested by the community

Doesn't it? :D

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.5.x and cherry-picked to 8.4.x. Thanks!

  • catch committed 839d67f on 8.5.x 
    Issue #2922018 by jhedstrom, amateescu: Set revision creation time when...

  • catch committed f519bff on 8.4.x 
    Issue #2922018 by jhedstrom, amateescu: Set revision creation time when...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.