Since the internal page cache now has a dedicated cache bin (https://www.drupal.org/node/2896679), the example.settings.local.php file should be updated to reflect that. Currently, uncommenting the three $settings['cache']['bins'] lines in that file will not prevent the page from being cached during development. A line with $settings['cache']['bins']['page'] = 'cache.backend.null'; is needed.

CommentFileSizeAuthor
#9 interdiff-2921706-6-9-do-not-test.diff848 bytesdaniel korte
#9 update-example.settings.local_.php-with-page-cache-bin-2921706-9.patch1.56 KBdaniel korte
#6 update-example.settings.local_.php-with-page-cache-bin-2921706-6.patch1.23 KBbkosborne
#4 update-example.settings.local_.php-with-page-cache-bin-2921706-4.patch1.23 KBbkosborne
#2 update-example.settings.local_.php-with-page-cache-bin-2921706-2.patch444 bytesdaniel korte

Comments

Daniel Korte created an issue. See original summary.

daniel korte’s picture

daniel korte
he/him/his
Primary language English
Location Brooklyn, NY
commented
Status: Active » Needs review
Related issues: +#2889603: Split the internal page cache from the rest of the render cache
StatusFileSize
new update-example.settings.local_.php-with-page-cache-bin-2921706-2.patch444 bytes

This patch adds the necessary line.

daniel korte’s picture

daniel korte
he/him/his
Primary language English
Location Brooklyn, NY
commented
Issue tags: +DX (Developer Experience)
bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented
StatusFileSize
new update-example.settings.local_.php-with-page-cache-bin-2921706-4.patch1.23 KB

Was about to create this issue myself! Thanks.

I updated it to include a whole new comment block instead, and remove the reference to the page cache in the render cache comment block.

Note that there are now 4 large comment blocks with largely the same comments about disabling certain caches. At this point it may make sense to create one single comment block that explains how to disable any cache bin, and provided commented out implementations for each bin provided by core?

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

This is a nice small addition!

bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented
StatusFileSize
new update-example.settings.local_.php-with-page-cache-bin-2921706-6.patch1.23 KB

Missed a couple words to swap out as I read this over again.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +D8 cacheability, +Documentation

We totally missed this in #2889603: Split the internal page cache from the rest of the render cache.

RTBC++

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work 
+++ b/sites/example.settings.local.php
@@ -75,6 +75,20 @@
+ * Do not use this setting until after the site is installed.

This looks good cut can we change that line to "Only use this setting once the site has been installed" and maybe give a reason?

daniel korte’s picture

daniel korte
he/him/his
Primary language English
Location Brooklyn, NY
commented
Status: Needs work » Needs review
StatusFileSize
new update-example.settings.local_.php-with-page-cache-bin-2921706-9.patch1.56 KB
new interdiff-2921706-6-9-do-not-test.diff848 bytes

I found where the decision was made to keep this line brief since the reason for it's existence might be a bug and the example.settings.local.php file is already long. See the relevant discussion here: #2321407-9: Suggested setting in example.settings.local.php for render doesn't work in install

Either way here is a new patch that changes those lines to the language from #8 if that is preferable.

daniel korte’s picture

daniel korte
he/him/his
Primary language English
Location Brooklyn, NY
commented
Status: Needs review » Reviewed & tested by the community
anavarre’s picture

anavarre
Primary language French
Location 🇪🇺
commented
Status: Reviewed & tested by the community » Needs review

@Daniel Korte - Please don't RTBC your own patch. See https://www.drupal.org/patch/review#review

daniel korte’s picture

daniel korte
he/him/his
Primary language English
Location Brooklyn, NY
commented

Yeah, sorry. I wasn't sure since it was just a minor comment update and it was already RTBC before that.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Yeah I think self-RTBC'ing for a comment-only reroll is fine.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.6.x and cherry-picked to 8.5.x. Thanks!

  • catch committed a43d80c on 8.6.x 
    Issue #2921706 by Daniel Korte, bkosborne: Update example.settings.local...

  • catch committed ce3bd36 on 8.5.x 
    Issue #2921706 by Daniel Korte, bkosborne: Update example.settings.local...
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Thanks, @catch, and thank you especially, @Daniel Korte! :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.