Problem/Motivation

Errors when running a migration with a test db that does not have translations and content_translation is not installed. The d6_taxonomy_term_translation migration is discovered and tries to run, when it should only be discovered when content_translation is enabled.

This is the error:

pgrading d6_taxonomy_term_translation
 [error]  Drupal\Core\Database\IntegrityConstraintViolationException: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'langcode' cannot be null: UPDATE {taxonomy_term_data} SET tid=:db_update_place3
WHERE tid = :db_condition_placeholder_0; Array
(
    [:db_update_placeholder_0] => 1
    [:db_update_placeholder_1] => catalog
    [:db_update_placeholder_2] => c96b0c82-ce2a-4a3d-b883-8feeb2801430
    [:db_update_placeholder_3] => 
    [:db_condition_placeholder_0] => 1
)
 in Drupal\Core\Database\Connection->handleQueryException() (line 683 of /opt/sites/d8/core/lib/Drupal/Core/Database/Connection.php). 

Proposed resolution

Move d6_taxonomy_term_translation and tests to content translation module.

Remaining tasks

Write a patch
commit

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Members fund testing for the Drupal project. Drupal Association Learn more

Comments

quietone created an issue. See original summary.

quietone’s picture

Removed the parent issue and kept it as related

Jo Fitzgerald’s picture

Issue summary: View changes
Status: Active » Needs review
FileSize
1.23 KB
1.26 KB

Moved d6_taxonomy_term_translation and tests to content translation module. Patches for both 8.4.x and 8.5.x.

(Minor correction to IS)

The last submitted patch, 3: 2920598-3-8_5.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 3: 2920598-3-8_4.patch, failed testing. View results

Jo Fitzgerald’s picture

Status: Needs work » Needs review
FileSize
1.44 KB
1.48 KB

Corrected the test failure(s).

quietone’s picture

Status: Needs review » Reviewed & tested by the community

Jo Fitzgerald, thanks. This looks great. And I have been working all day with this patch, it definitely works. And, yes without the patch the screen full of errors is still there.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.5.x and 8.4.x, thanks!

  • catch committed 5f9a75f on 8.5.x
    Issue #2920598 by Jo Fitzgerald, quietone: Move...

  • catch committed da16170 on 8.4.x
    Issue #2920598 by Jo Fitzgerald, quietone: Move...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.