Problem/Motivation
Errors when running a migration with a test db that does not have translations and content_translation is not installed. The d6_taxonomy_term_translation migration is discovered and tries to run, when it should only be discovered when content_translation is enabled.
This is the error:
pgrading d6_taxonomy_term_translation
[error] Drupal\Core\Database\IntegrityConstraintViolationException: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'langcode' cannot be null: UPDATE {taxonomy_term_data} SET tid=:db_update_place3
WHERE tid = :db_condition_placeholder_0; Array
(
[:db_update_placeholder_0] => 1
[:db_update_placeholder_1] => catalog
[:db_update_placeholder_2] => c96b0c82-ce2a-4a3d-b883-8feeb2801430
[:db_update_placeholder_3] =>
[:db_condition_placeholder_0] => 1
)
in Drupal\Core\Database\Connection->handleQueryException() (line 683 of /opt/sites/d8/core/lib/Drupal/Core/Database/Connection.php).
Proposed resolution
Move d6_taxonomy_term_translation and tests to content translation module.
Remaining tasks
Write a patch
commit
User interface changes
N/A
API changes
N/A
Data model changes
N/A
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 2920598-6-8_4.patch | 1.48 KB | jofitz |
| #6 | 2920598-6-8_5.patch | 1.44 KB | jofitz |
| #3 | 2920598-3-8_4.patch | 1.26 KB | jofitz |
| #3 | 2920598-3-8_5.patch | 1.23 KB | jofitz |
Comments
Comment #2
quietone commentedRemoved the parent issue and kept it as related
Comment #3
jofitzMoved d6_taxonomy_term_translation and tests to content translation module. Patches for both 8.4.x and 8.5.x.
(Minor correction to IS)
Comment #6
jofitzCorrected the test failure(s).
Comment #7
quietone commentedJo Fitzgerald, thanks. This looks great. And I have been working all day with this patch, it definitely works. And, yes without the patch the screen full of errors is still there.
Comment #8
catchCommitted/pushed to 8.5.x and 8.4.x, thanks!