Closed (works as designed)
Project:
Drupal core
Version:
8.7.x-dev
Component:
layout_discovery.module
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
27 Oct 2017 at 19:19 UTC
Updated:
25 Aug 2018 at 18:36 UTC
Jump to comment: Most recent
Comments
Comment #2
xjmThis is major (where "major" is "critical bug for one subsystem"). If we'd caught it before, it would have blocked making Layout Discovery stable.
Comment #4
tim.plunkettComment #6
pcate commentedThis seems like a case I could help with, but I want to make sure I'm not misunderstanding the scale and scope of the issue.
For the layout_discovery module I see the following CSS files which use flexbox:
threecol_25_50_25/threecol_25_50_25.cssthreecol_33_34_33/threecol_33_34_33.csstwocol/twocol.csstwocol_bricks/twocol_bricks.cssAre these the CSS files which need RTL support added? Are there any others?
Am I correct that this should be done via adding
[dir="rtl"]CSS selectors and changing the flex direction?Comment #7
dead_armComment #8
dead_armFlexbox takes the language direction into account on its own, so we do not need to add additional CSS to reverse the layouts for rtl languages.
This Mozilla documentation for Flexbox describes the behavior for
rowandrow-reverse, but the same applies towrapandwrap-reverse, which is what the layouts are using.Comment #9
dead_armComment #10
tim.plunkettThanks!