Link Trail by Path not working on Views with caching enabled

Hi firfin,

Could you post an export of your View here?

It should be functional.

Thanks

This isn't functional for me either.

I have a view of shop categories based on taxonomy terms with the following URL pattern:
example.com/en/shop/category-1
example.com/en/shop/category-2
example.com/en/shop/category-3

No matter what page I am on in the shop, only category-1 gets the active link. It's as if it is only looking at /shop and not the following parts of the URL. Even if I am at example.com/en/shop/category-3/product-123, category-1 keeps the active-trail.

I'm using the latest Pathauto and D8.6.

Thanks if you can look at this.

Update: Setting the view's caching to none fixed it.

I wonder if there is a way to fix this without changing the Views settings...

My log is full of PHP notices (issue here) in D8.6.7. Otherwise module is still working fine.

Hi,

Is this issue still valid ?

(reopen if needed)

Thanks.

Hi,

All working for me on anchors - i.e. it is adding the class correctly.
Great little module, thanks.

I agree with markdc though, I am seeing errors in the Watchdog like this...

InvalidArgumentException: Route required in Drupal\Core\Url::fromRouteMatch() (line 167 of /home/<...>/public_html/core/lib/Drupal/Core/Url.php)
#0 /home/<...>/public_html/modules/link_trail_by_path/link_trail_by_path.module(51): Drupal\Core\Url::fromRouteMatch(Object(Drupal\Core\Routing\CurrentRouteMatch))
#1 /home/<...>/public_html/core/lib/Drupal/Core/Theme/ThemeManager.php(287): link_trail_by_path_preprocess_links(Array, 'links', Array)
#2 /home/<...>/public_html/core/lib/Drupal/Core/Render/Renderer.php(431): Drupal\Core\Theme\ThemeManager->render('links', Array)
#3 /home/<...>/public_html/core/lib/Drupal/Core/Render/Renderer.php(200): Drupal\Core\Render\Renderer->doRender(Array, true)
#4 /home/<...>/public_html/core/lib/Drupal/Core/Render/Renderer.php(156): Drupal\Core\Render\Renderer->render(Array, true)
#5 /home/<...>/public_html/core/lib/Drupal/Core/Render/Renderer.php(573): Drupal\Core\Render\Renderer->Drupal\Core\Render\{closure}()
#6 /home/<...>/public_html/core/lib/Drupal/Core/Render/Renderer.php(157): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure))
#7 /home/<...>/public_html/core/lib/Drupal/Core/Render/Renderer.php(171): Drupal\Core\Render\Renderer->renderPlain(Array)
#8 /home/<...>/public_html/core/modules/big_pipe/src/Render/BigPipe.php(693): Drupal\Core\Render\Renderer->renderPlaceholder('callback=user.t...', Array)
#9 /home/<...>/public_html/core/modules/big_pipe/src/Render/BigPipe.php(547): Drupal\big_pipe\Render\BigPipe->renderPlaceholder('callback=user.t...', Array)
#10 /home/<...>/public_html/core/modules/big_pipe/src/Render/BigPipe.php(305): Drupal\big_pipe\Render\BigPipe->sendPlaceholders(Array, Array, Object(Drupal\Core\Asset\AttachedAssets))
#11 /home/<...>/public_html/core/modules/big_pipe/src/Render/BigPipeResponse.php(112): Drupal\big_pipe\Render\BigPipe->sendContent(Object(Drupal\big_pipe\Render\BigPipeResponse))
#12 /home/<...>/public_html/vendor/symfony/http-foundation/Response.php(374): Drupal\big_pipe\Render\BigPipeResponse->sendContent()
#13 /home/<...>/public_html/index.php(20): Symfony\Component\HttpFoundation\Response->send()
#14 {main}

Since it looks like this issue (#2918474) is primarily related to Link Trail by Path not working with Views unless caching is disabled, I'm going to update the title & description to reflect that.

Regarding the log errors (in #8 and #10), I've created a separate issue for the PHP user error: InvalidArgumentException: Route required message we're seeing in site logs using Link Trail by Path. Please see #3186839.

I unfortunately don't have bandwidth to work on these issues, and it looks like the maintainer, Pol, is no longer using Drupal, so this module may need a new maintainer. Pol did mention in the linked issue that he would be willing to help commit patches if the community is able to help out, here.

The problem here is that the view doesn't know it should vary its cache per page. For now I've added a custom hook in a separate module that solves this problem in my project by invalidating the render cache only right after the view with the cache problem has rendered. Completely disabling the views cache will result in a major performance penalty, this will disable only the render cache and only for the view.

/**
 * Implements hook_views_pre_view().
 */
function mymodule_views_pre_view(ViewExecutable $view, $display_id, array &$args) {
  if ($view->id() === '<YOUR VIEW HERE>') {
    $result = \Drupal::database()->select('cache_render')
      ->fields('cache_render', ['cid'])
      ->condition('cid', 'views:fields:<YOUR VIEW HERE>:<YOUR VIEWS DISPLAY ID HERE>%', 'LIKE')
      ->execute()
      ->fetchAllAssoc('cid');
    \Drupal::cache('render')->deleteMultiple(array_keys($result));
  }
}

Hello,

I'm indeed no more using Drupal but I'm still here to submit things if it's needed.

Please do not submit patches, but create a merge request so I can review it quickly and merge it if necessary.

Thanks!