Problem/Motivation

In the test data function providerTestCleanCssIdentifier in core/tests/Drupal/Tests/Component/Utility/HtmlTest.php

the comment on line 70:

"Verify that invalid characters (including non-breaking space) are stripped from the identifier." 

references line 71 when it should reference line 73.

The comment on line 72:

"Verify that double underscores are not stripped from the identifier." 

references line 73 when it should reference line 71.

Proposed resolution

Switch the two comments so they reference the correct lines.

CommentFileSizeAuthor
#6 xjm-post.png7.94 KBvaplas
#2 2917915-2.patch1.01 KBPCate
Members fund testing for the Drupal project. Drupal Association Learn more

Comments

PCate created an issue. See original summary.

PCate’s picture

chiranjeeb2410’s picture

Status: Active » Reviewed & tested by the community

@PCate,

Patch resolves the issue. RTBC good to go.

  • xjm committed 0a81f02 on 8.5.x
    Issue #2917915 by PCate: providerTestCleanCssIdentifier line comments...

  • xjm committed 2fafc21 on 8.4.x
    Issue #2917915 by PCate: providerTestCleanCssIdentifier line comments...
vaplas’s picture

Version: 8.5.x-dev » 8.4.x-dev
Status: Reviewed & tested by the community » Fixed
FileSize
7.94 KB

:P

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.