Follow-up to #2914710: JS codestyle: padded-blocks

Style error information

https://eslint.org/docs/rules/padded-blocks

Remark

SPACE change only.

How to Review

## 1. Apply Patch
## 2. Review Code Changes
## 3. Confirm no Code Standard Errors
yarn & yarn lint:core-js-passing
## 4.1 If `NO` errors, mark the issue as `Reviewed & tested by the community` (Don't be shy, we're all friendly)
## 4.2 If `HAS` errors, fix it and upload a new patch (Just do it and you can!!!)

Background

- #2912962: Step 1 JS codestyle: [meta] Fix JS coding standards in core

- We adapted the airbnb coding standard (#2815077: Adopt airbnb javascript style guide v14.1 as new baseline javascript coding standards for Drupal 8 core and contrib), but we are not fully compliant to it yet.

More Information

- Using ES6 in Core
https://www.drupal.org/node/2815083

- To find JS code standard errors stats
yarn & yarn lint:core-js-stats

Valuable Follow-up

- N/A

CommentFileSizeAuthor
#2 2917303-2.patch712 bytesalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 2917303-2.patch712 bytes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

I've updated the core committer hooks so that this shouldn't happen again - see https://github.com/alexpott/d8githooks/commit/38f5a71845d339ef9f148b8562...

GrandmaGlassesRopeMan’s picture

GrandmaGlassesRopeMan
he/him
Primary language English
Location 🌎
commented
Status: Needs review » Reviewed & tested by the community

🚀

  • xjm committed 5d01c25 on 8.5.x 
    Issue #2917303 by alexpott: JS codestyle: padded-blocks revisited
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Before:

Errors:
==============================
no-use-before-define: 75
max-len: 70
camelcase: 65
no-restricted-syntax: 54
no-shadow: 42
no-useless-escape: 19
new-cap: 18
default-case: 16
no-multi-assign: 14
no-continue: 9
no-new: 9
padded-blocks: 2
no-throw-literal: 1

After:

Errors:
==============================
no-use-before-define: 75
max-len: 70
camelcase: 65
no-restricted-syntax: 54
no-shadow: 42
no-useless-escape: 19
new-cap: 18
default-case: 16
no-multi-assign: 14
no-new: 9
no-continue: 9
no-throw-literal: 1

Committed and pushed to 8.5.x. Thanks! It doesn't cherry-pick cleanly to 8.4.x, but since the other coding standards fixes have mostly not been backported as per #2912962-7: Step 1 JS codestyle: [meta] Fix JS coding standards in core so we can pursue a backport later as part of all that if needed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.