Rename to "workspaces"

+1 for workspaces instead of workspace - I missed that it was not called workspaces.module in the review as the issue was called workspaces.

Assigning to catch.

If the core module is beta then it will need to stay with that name. So "wait until the upgrade path has a proof of concept" only works if the module does not become beta and only stays in 8.7.x. (Unless the upgrade path proof of concept already exists, in which case that is not a blocker anymore.)

I started looking into how hard this rename would be, and here's how far I got. Some tests are failing so I probably missed a few places, but I didn't finish it because, while looking a bit through the code base after the rename, I think I would prefer keeping the singular form.

A few fixes later, I think this should cover everything.

I think a plural module name is better while retaining the singluar in most (if not all?) class names.

+1 to the latest patch

Rerolled after #2975334: Prevent changes that would leak into the Live workspace and fixed the remaining failures.

Did a thorough line-by-line review and found only a comment that needed to be re-wrapped. I think this patch is good to go if we choose to rename the module.

One really good thing about not clashing with the contrib module name is that it makes upgrading simpler. If the names clash you don't just have to uninstall the contrib module you also have to completely remove the code - otherwise Drupal will not find the core module.

Another thing this will make simpler is if there are contrib or custom modules that depend on the contrib workspace module. Having a different namespace and module name means that we won't have to cope with incompatibilities or very hard to debug bugs caused by people using these module unexpectedly with the core module.

Rerolled after #2949991: Add workspace UI in top dialog.

I quickly scanned the code and it looks straightforward, @alexpott signed off in #15, so removing the tag.

Leaving this to @catch as it's assigned to him.

OK I don't have a strong opinion on singular vs. plural module names, but making the contrib -> core upgrade path easier is good, and it's nice that namespaces allow us to keep the class names singular, especially around entities - can't imagine what the first 10+ years of Drupal would have been like with nodes_load().

Patch looks fine to me but I only reviewed the first 60% of it, so just un-assigning for now.

@catch, I can assure you that the remaining 40% of the patch is as boring as the first part :D

Just a note. I had to hotfix 8.6.x's \Drupal\Tests\config\Functional\ConfigImportAllTest because of the removal of the workspace module from that branch. Atm it has a hardcoded reference to the workspace module.

+++ b/core/modules/workspaces/workspaces.install
@@ -2,15 +2,15 @@
-function workspace_requirements($phase) {
+function workspaces_requirements($phase) {

I think we can/need to add to this. As we have a different name we can declare the incompatibility with the contrib workspace module - and in the message we can tell people how to upgrade!

@alexpott, good point! I started a documentation page for this upgrade path (https://www.drupal.org/docs/8/core/modules/workspace/upgrading-from-the-...) and linked it in a new install requirement error.

@alexpott did a live review and found a few more things that should be renamed.

@amateescu nice work! #27 changes generic extension CSS rules from workspace to workspaces and tidies up other extension specific naming to use workspaces instead of workspace.

It's great that the new name allows us a hook_requirements implementation that actually helps people upgrade. RTBCing - hopefully this is green.

Saving credits

Committed ab30572 and pushed to 8.7.x. Thanks!

Fix component following module rename.

I backported this to 8.6.x so the shiny new Workspaces module is there.