Use the minimum_age_to_delete variable in the node revision deletion

The project page says:

7.x-3.0-beta1 released 10 August 2017
Now you can delete revisions based on age and inactivity. But more test are needed before the final release.

But this functionality isn't working yet, as noted in this task! It appears to be only half built -- it's in the UI but it's not actually in the _node_revision_delete_do_delete() function as noted in this task. This threw me off and I imagine it will others. Maybe update the 3.0-beta1 release note so it doesn't mislead?

Has this been fixed or not? Can I rely on Minimum age of revisions to delete? Or was this a documentation issue?

Patch attached to accomplish this functionality. I did test as thoroughly as I could and will continue to do so, but it needs to put through it's paces.

I'll take a look

@adriancid, I did include those lines. The $when_to_delete variable is still there, but I took the strtotime call out and put it into a function called _node_revision_delete_determine_time(). The $minimum_age_to_delete is included in the second query:

  // Limit the candidates by the minimum age variable. This cannot be combined
  // with the above query because it will remove results that should be 
  // included.
 if (count($candidates)) {
   $query = db_select('node_revision', 'r');
   $query->fields('r', array('nid'));
   $query->condition('r.nid', $candidates);
   $query->condition('r.timestamp', $minimum_age_time, '<');
   $query->orderBy('r.nid');
   $candidates = $query->execute()->fetchCol();
 }

Missing a groupBy probably...I'll take a look.

Yup, adding the group by worked. New patch attached.

Tagging for DrupalNorth 2019

On a 20Gb database with 600.000 revisions the patch at #16 made the page admin/config/content/node_revision_delete unable to load and the Drush command unresponsive. I joined both queries into one and now the query just takes between 2 to 4 seconds. @slydevil said that joining them together may mean that the script could delete incorrect revisions but after looking at the code I did not get that impression. Can you clarify @slydevil?