I'm getting an error in my hourly cron run:

Fatal error: Call to undefined function: check_plain() in /home/wadsworth/www/jeaun.com/includes/xmlrpc.inc on line 67

It appears that the new version of xmlrpc.inc in drupal 4.5.5 contains a call to the check_plain function, which I believe only exists in drupal 4.6. I'm guessing that those function calls should be changed to drupal_specialchars, since the two functions appear to be doing essentially the same thing.

I've attached a patch that switches the function calls.

I can't seem to upload the patch (although it's easy enough to make manually,) so here it is:

67c67
<       return '<string>'. check_plain($xmlrpc_value->data) .'</string>';
---
>       return '<string>'. drupal_specialchars($xmlrpc_value->data) .'</string>';
80c80
<         $return .= "  <member><name>". check_plain($name) ."</name><value>";
---
>         $return .= "  <member><name>". drupal_specialchars($name) ."</name><value>";
CommentFileSizeAuthor
#3 29149_01.patch929 bytespuregin
xmlrpc.inc.underwaterguy.patch342 bytessubakva

Comments

subakva’s picture

Okay, so the patch was uploaded. The preview function wasn't working for some reason, so I couldn't see that it was already there.

Uwe Hermann’s picture

Status: Active » Needs review

Hi, thanks for the report. Please provide patches in a proper format, though, see http://drupal.org/patch.

puregin’s picture

StatusFileSize
new929 bytes

I can confirm that this problem exists and that underwaterguy's patch fixes the problem. I am supplying his patch in unified diff format.

Djun

chx’s picture

Status: Needs review » Fixed

This is already fixed in CVS and we will act upon.

chx’s picture

One more note: when 4.7 comes (and it will sooner than later -- September 1 is feature freeze day), 4.5 will not be supported any more. Please consider upgrading.

Anonymous’s picture

pagnes@www.prolocoveroli.it’s picture

Anonymous’s picture

Status: Fixed » Closed (fixed)