Closed (fixed)
Project:
Drupal core
Version:
8.6.x-dev
Component:
layout_builder.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
6 Oct 2017 at 18:54 UTC
Updated:
3 Mar 2018 at 05:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
tim.plunkett#2232427: Allow field types to control how properties are mapped to and from storage
Comment #3
samuel.mortenson@tim.plunkett I reviewed the module and couldn't find any security issues specifically related to serialization. When you use a serialized column the unserialization/serialization happens before a user gets or sets the value of a field, which means that object injection is not possible by setting the value of the field to a serialized string. That said, I discovered follow up items we should address in new issues:
Comment #4
tim.plunkettThanks @samuel.mortenson!
Comment #6
samuel.mortensonI've created #2942975: [PP-1] Expose Layout Builder data to REST and JSON:API and #2942976: Add REST test coverage for Layout Builder, which cover points one and two from comment #3.
I don't think we should file an issue for #3.3 until we start work on a Normalizer - if we find that supporting the current storage format is too complicated, we can look at moving to JSON.
Comment #7
jibranThere is a todo in core pointing towards this issue.
Comment #8
jibranComment #9
samuel.mortenson@jibran Great catch, thanks!
Comment #10
alexpottCommitted and pushed b5d11aeac5 to 8.6.x and fcd1465565 to 8.5.x. Thanks!
Comment #13
tim.plunkett