Problem/Motivation

When opening an iconset's edit/add form, there's a couple of notices popping up. The same happens when saving an icon set. It's simply caused by missing properties of the config entity class. Adding those will solve the problem and also improve autocompletion in IDE's such as phpstorm.

Proposed resolution

Add the missing properties to IconSet.php according to menu_svg_icons.schema.yml.

CommentFileSizeAuthor
#4 screenshot-svv.dev-2017-10-03-09-20-17-558.png908.14 KBs_leu
#3 missing-properties-on-config-entity_2913414_3.patch838 bytess_leu
#2 missing-properties-on-config-entity_2913414_2.patch1.24 KBs_leu

Comments

s_leu created an issue. See original summary.

s_leu’s picture

s_leu commented
Status: Active » Needs review
StatusFileSize
new missing-properties-on-config-entity_2913414_2.patch1.24 KB

Here's a patch that completes the property definition on the config entity class.

s_leu’s picture

s_leu commented
StatusFileSize
new missing-properties-on-config-entity_2913414_3.patch838 bytes
s_leu’s picture

s_leu commented
StatusFileSize
new screenshot-svv.dev-2017-10-03-09-20-17-558.png908.14 KB

Adding a screenshot to better illustrate the issue.

  • AndersNielsen committed 2257682 on 8.x-1.x authored by s_leu 
    Issue #2913414 by s_leu: Notices due to missing properties in entity...
AndersNielsen’s picture

AndersNielsen commented
Status: Needs review » Fixed

Thank you for the work, pushed to dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.