Add Drush 9+ command support

The command should be added in a drush.services.yml, think I

And in composer.json.
Patch attached

sorry, #5 was wrong…

Thanks for working on that! As a maintainer, i see the issue that this patch will introduce code duplicated in 2 places which makes any subsequent patch cumbersome and error-prone. Fortunately the config-split guys have solved that problem well and - even better - documented their effort. It's super simple.
So if this patch is reworked that way, we can move it in.

(Please also include #2921750: Drush command doesn't work with verify option)

Also see RTBC #2921750: Drush command doesn't work with verify option.

New version, tested with Drush 9.2.

What did you change? As far as i see it, stage_file_proxy.drush8.inc still contains dup code to the command service. See #8.

I did not "change" anything: I hadn't seen the earlier implementation so it has been redone independently. The situation wrt drush 8/9 code is similar to the one about Features, it seems.

* Removed code duplication
* Replaced deprecated Unicode::* calls with mb_*.
* Fixed some coding standards
* Added #2921750: Drush command doesn't work with verify option.

fixed coding standards.

This is the right patch.

Drush 10 has just been released. It would be good to support it in this patch.
https://github.com/drush-ops/drush/releases/tag/10.0.0

@Chi did you test it? An example of upgrading is #3071228: Drush 10 compat which seems pretty lightweight.

i am currently testing it from the contribution day on drupalcon :)
well, just the drush 9 one.
will report that

patch fails against the 8.x-1.x branch.

@greggles, right, supporting Drush 10 is likely be one line change. So it makes sense to make it in this issue.

made the patch apply to 8.x-1.x branch again.
did not test yet.

confirms patch @27 works for drush 9

could we get this patch already submitted and have drush 10 for another issue?
It works for 9, this issue is 2 years old...

I'm fine with the approach of committing this for Drush9 and pushing drush10 to another issue in general, though the changes for 10 are likely pretty small.

Anyone else want to review this for 9. I personally don't use this functionality so I'm not well suited to test it.

Looks pretty good. I noticed

"stage_file_proxy.drush.services.yml": "^9"

Change this line in composer.json to ^9 || ^10 to get full Drush 10 support. Nothing more is needed.

$logger->error(
+        'Configure stage_file_proxy.settings.origin in your settings.php (see INSTALL.txt).'
+      );
+
+      return;

The convention is to throw an Exception in cases like this, not just log an error.

Needs work based on #31.

Thanks for the review, Moshe!

Here is a patch with #31 comment applied.

I'll submit just after a patch adding a skippable progress bar

I tested the two patches and both work

And here is the patch with the skippable progress bar

Fixed the patch to be applied correctly.

Attached the patch.

Last patch failed to apply correctly according to CI.

@moshe does #34 look good to you? Seems like it fixes your feedback and addresses another issue and it applies, according to testbot.

Yeah, looks good. There are still a couple instances of $logger->error() but it looks to me like thats not a true command error, but rather reporting results. So $logger->error() is fine for that use.

Great, thanks, everyone for your help!

Now committed.