Problem/Motivation

While working on media revisionable entity part, found this UI issue

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#13 2912333-13--before.png131.46 KBphenaproxima
#10 Screenshot patch 2912333-4 revision unchecked.png179.03 KBgilesmc
#10 Screenshot patch 2912333-4.png186.56 KBgilesmc
#4 2912333-4.patch2.4 KBvijaycs85
#4 2912333-test-only-4.patch1.12 KBvijaycs85
#2 2912333-2.patch1.29 KBvijaycs85
Screen Shot 2017-09-27 at 12.49.32.png253.67 KBvijaycs85
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vijaycs85 created an issue. See original summary.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer and at TATA Consultancy Services, Solathat for Pfizer, Inc. commented
Status: Active » Needs review
Issue tags: +Needs tests
FileSize
2912333-2.patch1.29 KB

Thanks @phenaproxima for pairing up to debug. It turns out that we don't use the field name key from meta data of entity definition. We also need tests.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs review » Needs work

Kicking back to NW for tests.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer and at TATA Consultancy Services, Solathat for Pfizer, Inc. commented
Status: Needs work » Needs review
FileSize
2912333-test-only-4.patch1.12 KB
2912333-4.patch2.4 KB

Here we go!

The last submitted patch, 4: 2912333-test-only-4.patch, failed testing. View results

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer and at TATA Consultancy Services, Solathat for Pfizer, Inc. commented
Issue tags: -Needs tests
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Issue tags: +Needs screenshots

Let's get a screenshot of this just for...I dunno, completeness' sake. Then this is RTBC as far as I'm concerned.

gilesmc’s picture

gilesmc CreditAttribution: gilesmc as a volunteer and commented

I am working on this at the DrupalCon Vienna sprint

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer and at TATA Consultancy Services, Solathat for Pfizer, Inc. commented
Issue tags: +Vienna2017
gilesmc’s picture

gilesmc CreditAttribution: gilesmc as a volunteer and commented
FileSize
Screenshot patch 2912333-4.png186.56 KB
Screenshot patch 2912333-4 revision unchecked.png179.03 KB

Hi there,

after some really *interesting* problems upgrading Drush, I finally managed to apply the patch and take some screenshots.

Regards,
Giles

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer and at TATA Consultancy Services, Solathat for Pfizer, Inc. commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs screenshots

Thanks @gilesmc.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented

Thanks! +1 RTBC.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
FileSize
2912333-13--before.png131.46 KB

To help the cause, here is a screenshot of what things look like before applying this patch. Regardless of whether it's a new or existing entity.

  • webchick committed 210ca8a on 8.5.x 
    Issue #2912333 by vijaycs85, gilesmc, phenaproxima: Revision log field...

webchick credited webchick.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented
Status: Reviewed & tested by the community » Fixed

Yeah, that's pretty silly. :)

Simple fix, has tests, woot!

Committed and pushed to 8.5.x and backported to 8.4.x. Thanks!

  • webchick committed 46c3896 on 8.4.x 
    Issue #2912333 by vijaycs85, gilesmc, phenaproxima: Revision log field...
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Reviewed & tested by the community » Fixed

For some reason, drupal.org still thinks this is RTBC. Nope!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.