Upgrading to Simple XML Sitemap version 2.10 breaks Domain Simple Sitemap due to class refactoring. The BatchUrlGenerator class has been removed. In its place are UrlGeneratorBase, EntityUrlGenerator, and CustomUrlGenerator. I made a first pass at refactoring the Domain Simple Sitemap BatchUrlGenerator class into EntityUrlGenerator and CustomUrlGenerator.

Comments

slbrassard created an issue. See original summary.

gbyte’s picture

Instead of refactoring this module to be compatible with simple_sitemap, why not direct your efforts to make simple_sitemap compatible with domain_access?

#2911909: Merge functionaity into simple_sitemap

keopx’s picture

Status: Active » Needs work

I can not apply the patch

+++ b/domain_simple_sitemap.services.yml
@@ -48,5 +47,19 @@ services:
diff --git a/src/Batch/Batch.php b/src/Batch/Batch.php

What is this change?

$ git apply --check domain-simple-sitemap--url-generator-refactor.patch
error: modules/contrib/migrate_tools/migrate_tools.drush.inc: No existe el fichero o el directorio                                                                                                                        
error: modules/contrib/migrate_tools/src/Controller/MessageController.php: No existe el fichero o el directorio                                                                                                           
error: modules/contrib/migrate_tools/src/Controller/MigrationController.php: No existe el fichero o el directorio                                                                                                         
error: modules/contrib/migrate_tools/src/Controller/MigrationListBuilder.php: No existe el fichero o el directorio                                                                                                        
error: modules/contrib/simple_sitemap/README.md: No existe el fichero o el directorio                                                                                                                                     
error: modules/contrib/simple_sitemap/config/install/simple_sitemap.custom.yml: No existe el fichero o el directorio                                                                                                      
error: modules/contrib/simple_sitemap/config/install/simple_sitemap.settings.yml: No existe el fichero o el directorio                                                                                                    
error: modules/contrib/simple_sitemap/config/schema/simple_sitemap.schema.yml: No existe el fichero o el directorio
error: modules/contrib/simple_sitemap/js/simple_sitemap.fieldsetSummaries.js: No existe el fichero o el directorio
error: modules/contrib/simple_sitemap/js/simple_sitemap.form.js: No existe el fichero o el directorio
error: modules/contrib/simple_sitemap/js/simple_sitemap.sitemapEntities.js: No existe el fichero o el directorio
error: modules/contrib/simple_sitemap/simple_sitemap.api.php: No existe el fichero o el directorio
error: modules/contrib/simple_sitemap/simple_sitemap.info.yml: No existe el fichero o el directorio
error: modules/contrib/simple_sitemap/simple_sitemap.install: No existe el fichero o el directorio
error: modules/contrib/simple_sitemap/simple_sitemap.module: No existe el fichero o el directorio
error: modules/contrib/simple_sitemap/simple_sitemap.permissions.yml: No existe el fichero o el directorio
error: modules/contrib/simple_sitemap/simple_sitemap.services.yml: No existe el fichero o el directorio
error: modules/contrib/simple_sitemap/src/Batch/Batch.php: No existe el fichero o el directorio
error: modules/contrib/simple_sitemap/src/Batch/BatchUrlGenerator.php: No existe el fichero o el directorio
error: modules/contrib/simple_sitemap/src/Controller/SimplesitemapController.php: No existe el fichero o el directorio
error: modules/contrib/simple_sitemap/src/EntityHelper.php: No existe el fichero o el directorio
error: modules/contrib/simple_sitemap/src/Form/FormHelper.php: No existe el fichero o el directorio
error: modules/contrib/simple_sitemap/src/Form/SimplesitemapCustomLinksForm.php: No existe el fichero o el directorio
error: modules/contrib/simple_sitemap/src/Form/SimplesitemapEntitiesForm.php: No existe el fichero o el directorio
error: modules/contrib/simple_sitemap/src/Form/SimplesitemapSettingsForm.php: No existe el fichero o el directorio
error: modules/contrib/simple_sitemap/src/Simplesitemap.php: No existe el fichero o el directorio
error: modules/contrib/simple_sitemap/src/SitemapGenerator.php: No existe el fichero o el directorio
error: modules/contrib/simple_sitemap/src/Tests/SimplesitemapTest.php: No existe el fichero o el directorio
error: modules/contrib/simple_sitemap/tests/src/Unit/SimplesitemapTestBase.php: No existe el fichero o el directorio
error: modules/migrations/cornell_content_migration/config/install/migrate_plus.migration.faculty.yml: No existe el fichero o el directorio
mlzr’s picture

Upgrading to Simple XML Sitemap version 2.10 breaks Domain Simple Sitemap => subscribe. Same problem here.

I posted this in the "Simple XML Sitemap" queue bud it belongs here.

https://www.drupal.org/node/2912493

I am not a coder, hope you can find a solution somehow.

Marchello

j.b’s picture

Has anyone found a solution ?

This functionality is quite critical, we have some website with Domain access and each website requires its corresponding sitemap xml.

Should we revert back to an old version of simple xml site map ?

mlzr’s picture

j.b: in the time I was searching for a solution for a good sitemap for my 'domain access websites' I could not find a good working solution exept this one. Only Simple XML Sitemap + Domain Access Simple XML Sitemap was working and ok.

Bud now 'Domain Access Simple XML Sitemap' is not upgradable I have a major problem too...

Current I use the old versions; this is working and OK for now. Bud I hope there is a solution for a good sitemap with 'domain access' sooner or later!! .....

slbrassard’s picture

StatusFileSize
new23.72 KB

Sorry about that. I was a bit hasty in my patch creation. I've fixed it.

  • keopx committed 0817cd1 on 8.x-1.x authored by slbrassard
    Issue #2911863 by slbrassard, keopx: Upgrading to Simple XML Sitemap...
keopx’s picture

Status: Needs work » Fixed

Thank you @slbrassard!!!

slbrassard’s picture

Unfortunately, it looks like only some of the changes got committed. There should also be changes to the following files: "domain_simple_sitemap.services.yml", "Batch.php", "BatchUrlGenerator.php" (removed), "DomainSimpleSitemap.php", and "DomainSimpleSitemapGenerator.php". When you applied it, did you see those changes? Is there something wrong with the patch?

  • keopx committed 8339ab9 on 8.x-1.x authored by slbrassard
    Issue #2911863 by slbrassard, keopx: Upgrading to Simple XML Sitemap...
keopx’s picture

You are right @slbrassard.

Sorry for mistake.

j.b’s picture

Great latest versions work !

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.