Closed (fixed)
Project:
Domain Access Simple XML Sitemap
Version:
8.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
26 Sep 2017 at 16:29 UTC
Updated:
20 Oct 2017 at 05:55 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
gbyteInstead of refactoring this module to be compatible with simple_sitemap, why not direct your efforts to make simple_sitemap compatible with domain_access?
#2911909: Merge functionaity into simple_sitemap
Comment #3
keopxI can not apply the patch
What is this change?
Comment #4
mlzrUpgrading to Simple XML Sitemap version 2.10 breaks Domain Simple Sitemap => subscribe. Same problem here.
I posted this in the "Simple XML Sitemap" queue bud it belongs here.
https://www.drupal.org/node/2912493
I am not a coder, hope you can find a solution somehow.
Marchello
Comment #5
j.b commentedHas anyone found a solution ?
This functionality is quite critical, we have some website with Domain access and each website requires its corresponding sitemap xml.
Should we revert back to an old version of simple xml site map ?
Comment #6
mlzrj.b: in the time I was searching for a solution for a good sitemap for my 'domain access websites' I could not find a good working solution exept this one. Only Simple XML Sitemap + Domain Access Simple XML Sitemap was working and ok.
Bud now 'Domain Access Simple XML Sitemap' is not upgradable I have a major problem too...
Current I use the old versions; this is working and OK for now. Bud I hope there is a solution for a good sitemap with 'domain access' sooner or later!! .....
Comment #7
slbrassard commentedSorry about that. I was a bit hasty in my patch creation. I've fixed it.
Comment #9
keopxThank you @slbrassard!!!
Comment #10
slbrassard commentedUnfortunately, it looks like only some of the changes got committed. There should also be changes to the following files: "domain_simple_sitemap.services.yml", "Batch.php", "BatchUrlGenerator.php" (removed), "DomainSimpleSitemap.php", and "DomainSimpleSitemapGenerator.php". When you applied it, did you see those changes? Is there something wrong with the patch?
Comment #12
keopxYou are right @slbrassard.
Sorry for mistake.
Comment #13
j.b commentedGreat latest versions work !