Problem/Motivation

Currently, Scheduled Updates run during install and, depending on your configuration, will always print something similar to following message at the end of install:

Updater Publish multiple nodes at a certain time complete. Results: No updates were performed.
Updater Publish single node at certain time complete. Results: No updates were performed.

This is because Scheduled Updates run on cron, and the installer runs cron as part of install_finished(). We've had complaints that this is confusing to people who are installing Lightning - especially on Acquia Cloud where the default for one-click installs is through the UI.

Proposed resolution

I can't think of a situation where you would have a Scheduled Update that you wanted to run during install. In Scheduled Update's hook_cron, we should just bail out if drupal_installation_attempted() is true.

Remaining tasks

Patch forthcoming.

CommentFileSizeAuthor
#2 2911818-2.patch566 bytesbalsama

Comments

balsama created an issue. See original summary.

balsama’s picture

Assigned: balsama » Unassigned
Status: Active » Needs review
StatusFileSize
new566 bytes

Patch attached.

Status: Needs review » Needs work

The last submitted patch, 2: 2911818-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • smustgrave committed bab5c6d0 on 3.0.x
    feat: #2911818 Don't run updates during install
    
    By: balsama
    
smustgrave’s picture

Version: 8.x-1.x-dev » 3.0.x-dev
Status: Needs work » Fixed

Fine with this change.

Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.