Update versions of Stylelint dependencies.

CommentFileSizeAuthor
#26 2910706-26.patch46.45 KBjoelpittet
#21 2910706-21.patch46.46 KBalexpott
#21 18-21-interdiff.txt10.61 KBalexpott
#18 2910706-18.patch37.61 KByogeshmpawar
#14 2910706-14.patch37.6 KBjoelpittet
#11 2910706-11.patch70.1 KBjoelpittet
#5 update-stylelint-packages.patch69.69 KBdroplet
update-stylelint-packages.patch11.52 KBdroplet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

droplet created an issue. See original summary.

droplet’s picture

droplet CreditAttribution: droplet commented
Component: javascript » CSS
droplet’s picture

droplet CreditAttribution: droplet commented
Parent issue: #2809281: Use ES6 for core JavaScript development »
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer and at The University of British Columbia commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

@droplet, would you mind doing a reroll and putting the commands you used to update in the Issue Summary? There is an 8.4 available now and I don't know how fast we want to chase head?

droplet’s picture

droplet CreditAttribution: droplet commented
Status: Needs work » Needs review
FileSize
update-stylelint-packages.patch69.69 KB

For patch:
git reset --hard && yarn add -D stylelint stylelint-checkstyle-formatter stylelint-config-standard stylelint-no-browser-hacks && git diff > update-stylelint-packages.patch

For daily usages:
yarn upgrade-interactive --latest
(this command may not update the package.json if you runnnig an old version of Yarn)

There is an 8.4 available now and I don't know how fast we want to chase head?

For Stylelint, I think we only have to patch dev branch, once at the very end of a major release.

In some case, if we running sprite for issues like this #2866801: Update stylelint rules color-hex-length to be consistent with Drupal's CSS standards, we should keep it up-to-date to introduce more autofix for everyone. :p

droplet’s picture

droplet CreditAttribution: droplet commented
Issue tags: -Needs reroll

Status: Needs review » Needs work

The last submitted patch, 5: update-stylelint-packages.patch, failed testing. View results

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer and at The University of British Columbia commented
Status: Needs work » Reviewed & tested by the community

Thanks for the commands @droplet, I reran them to double check the result. Setting this to RTBC.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer and at The University of British Columbia commented
Status: Reviewed & tested by the community » Needs work

Oh we may need to add a few more overwriting rules until we fix some of the lint errors:

no-descending-specificity catches a lot.

I'd suggest adding these, your thought?

    "no-descending-specificity": null,
    "no-duplicate-selectors": null,
    "declaration-empty-line-before": null,

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer and at The University of British Columbia commented
Status: Needs work » Needs review
FileSize
2910706-11.patch70.1 KB

Adding those nulls in to make sure css:lint doesn't complain.

gapple’s picture

gapple
he/they
Primary language English
CreditAttribution: gapple as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 11: 2910706-11.patch, failed testing. View results

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer and at The University of British Columbia commented
Status: Needs work » Needs review
FileSize
2910706-14.patch37.6 KB

Looks like two packages are updated already.
stylelint-checkstyle-formatter and stylelint-no-browser-hacks
The versions haven't changed in this patch.

Also one less NULL 

+++ b/core/.stylelintrc.json
@@ -9,8 +9,11 @@
+    "declaration-empty-line-before": null,

Removed because it doesn't fail anymore.

gapple’s picture

gapple
he/they
Primary language English
CreditAttribution: gapple as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 14: 2910706-14.patch, failed testing. View results

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location 🇮🇳 Pune(MH)
CreditAttribution: yogeshmpawar at QED42 commented
Assigned: Unassigned » yogeshmpawar
yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location 🇮🇳 Pune(MH)
CreditAttribution: yogeshmpawar at QED42 commented
Assigned: yogeshmpawar » Unassigned
Status: Needs work » Needs review
FileSize
2910706-18.patch37.61 KB

Re-rolled the patch against 8.6.x branch because #14 patch failed to apply.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer and at The University of British Columbia commented
Status: Needs review » Reviewed & tested by the community

Thanks, I diffed the diffs and there is only patch context lines, back to RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce commented
Status: Reviewed & tested by the community » Needs work

Stylelint is on 9.1.1 now.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce commented
Status: Needs work » Needs review
FileSize
18-21-interdiff.txt10.61 KB
2910706-21.patch46.46 KB

Also a regression snuck into banner.css in umami. Fixing here so we have a clean run of the linting standards. It is a whitespace only change to very easy to review.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer and at The University of British Columbia commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC.

Here's the upstream changes between core and the latest for those interested
https://github.com/stylelint/stylelint/compare/7.13.0...9.1.1

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer and at The University of British Columbia commented
Parent issue: » #2865971: Use stylelint as opposed to csslint in core
Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
CreditAttribution: Mixologic at Drupal Association commented
Related issues: +#2866840: Use stylelint as opposed to csslint in DrupalCI

Also, this issue is blocking #2866840: Use stylelint as opposed to csslint in DrupalCI

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 21: 2910706-21.patch, failed testing. View results

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer and at The University of British Columbia commented
Status: Needs work » Reviewed & tested by the community
FileSize
2910706-26.patch46.45 KB

It applies with fuzz with patch -p1, failed on git apply. Here's a reroll and minor version change on the standard.

-   "stylelint-config-standard": "^18.1.0",
+   "stylelint-config-standard": "^18.2.0",

The linter runs without any errors still.

$ yarn run lint:css
yarn run v1.5.1
$ stylelint "**/*.css" || exit 0
✨  Done in 9.82s.

The change updates a dependency:
https://github.com/stylelint/stylelint-config-standard/compare/18.1.0......

Which is here:
https://github.com/stylelint/stylelint-config-recommended/compare/2.0.0....

Which removes declaration-block-no-redundant-longhand-properties which appears to have an attempt to be removed before.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 8b5cbee4fb to 8.6.x and ee7970c481 to 8.5.x. Thanks!

I've backported this to 8.5.x because this is only about linting CSS and the core package.json is not API. Plus this will unblock DrupalCI linting.

  • alexpott committed 8b5cbee on 8.6.x 
    Issue #2910706 by joelpittet, droplet, alexpott, Yogesh Pawar: Update...

  • alexpott committed ee7970c on 8.5.x 
    Issue #2910706 by joelpittet, droplet, alexpott, Yogesh Pawar: Update...
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer and at The University of British Columbia commented

Sweet! 🍬

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.