Follow-up to #2900112: Update non-Symfony dependencies in lock file before 8.4.0

Problem/Motivation

While we are updating Symfony in #2874909: Update Symfony components to 3.3.*, other dependencies still need to be updated.

Proposed resolution

  - Updating masterminds/html5 (2.2.2 => 2.3.0)
  - Updating zendframework/zend-diactoros (1.4.0 => 1.4.1)
  - Updating symfony-cmf/routing (1.4.0 => 1.4.1)

Remaining tasks

Fix it.

User interface changes

None

API changes

Hopefuly none.

Data model changes

None.

CommentFileSizeAuthor
#6 again_update-2909743-6.patch3.83 KBjibran
#2 again_update-2909743-2.patch2.56 KBjibran

Comments

jibran created an issue. See original summary.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Active » Needs review
StatusFileSize
new again_update-2909743-2.patch2.56 KB

composer update zendframework/zend-diactoros masterminds/html5

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
commented

Is masterminds really just used for that one test base?

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Needs review » Reviewed & tested by the community

Assuming the tests pass, this is fine.

I applied the patch, performed composer install, added config:platform:php:5.5.9 to composer.json, and then did composer update zendframework/zend-diactoros masterminds/html5

This resulted in no changed packages, so LTGM.

martin107’s picture

martin107 commented

As I pulled and inspected the changes from the parent issue ... I was thinking the same thing.

+1 from me.

It is good to see the output of "composer outdated" improving over time....

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new again_update-2909743-6.patch3.83 KB

Added symfony-cmf/routing (1.4.0 => 1.4.1) as well.

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
commented
Status: Needs review » Reviewed & tested by the community

For a few weeks now I have been thinking that we may want to propose a policy that before we open 8.X.x-alpha1, we composer update all of the non-problematic dependencies (pretty much everything except for Symfony and Twig?).

?

Otherwise, I am +1 on these. We have enough test coverage around these. If the latest doesn't come back green we have problem...

  • xjm committed 214c6b5 on 8.5.x 
    Issue #2909743 by jibran, mpdonadio, Mile23: Again update non-Symfony...

  • xjm committed 273fe84 on 8.4.x 
    Issue #2909743 by jibran, mpdonadio, Mile23: Again update non-Symfony...
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

@mpdonadio, yeah, I think we have the intent to update before each alpha in theory, but not as much in practice. OTOH this is the kind of thing that RC is for but OTOH any actual minor updates will have a beta deadline... Looking forward to the test improvements in this area.

I'm not totally sure that only Symfony and Twig are tricky; e.g. updating Guzzle was a pain and a half and we just got lucky we had a patch for it in the queue when we needed to release an update for httpoxy.

Committed to 8.5.x and cherry-picked to 8.4.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.