User access value wrong in blog.pages.inc

Same problem here using Drupal 6.9.

I think this should be fixed as it is the only place where 'edit own blog' is specified.

The only required change is on line 61 of blog.pages.inc file.

if (user_access('edit own blog')) {

should become

if (user_access('edit own blog entries')) {

It is stated in comment of system_update_6045() function that

* Blog module got "edit own blog" replaced with the more granular "create
* blog entries", "edit own blog entries" and "delete own blog entries"
* permissions. (...)

Hope to hear from someone for a positive feedback or a explanation on how it is like that.

Regards,

Seb

So here is the patch to allow roles with "edit own blog entries" permission to get the link in top of the /blogs page.

Hope it's ok as it is my first one.

Here is the new version.

The fix is different as the correct permission in D7 seems to be 'edit own blog content' instead of 'edit own blog entries' so I have made this little change in new patch.

Regards

I don't see any syntax error in the patch. Is this a test error ?

Regards

Hmm...there was an extra newline at the end of the patch file. Let's try this one.

Hmm...I rolled a new patch myself and fixed the permission to use the correct one 'create blog content', since the link that is used is for creating new blog content, and not editing it.

Sure you are right, 'create blog content' is far better.

So I guess 'create blog entries' will be the correct permission in 6.x

Thanks for reviewing this.

Regards,

Seb

Retest.

This time with an added assertion in blog.test that I've confirmed fails before the patch, and passes with the patch. Yay! Let's get this reviewed and fixed!

Looks good to me.

Comimtted to CVS HEAD. Thanks.

Needs a re-roll for the backport, without the test.

Re-roll for Drupal 6.

Hope it's ok.

Regards,

Wanjee

Looks good.

Yes, for Drupal 6, the good permission is "create blog entries". From system.install's update docs:

Blog module got "edit own blog" replaced with the more granular "create blog entries", "edit own blog entries" and "delete own blog entries"

Committed to Drupal 6, thanks!