Right now, trying to pull an entity that references a missing file (either directly or through a related entity) lead to an uncatched Guzzle exception, meaning the transaction aborts in the middle (some entities might have been saved) and an hard to diagnose fail for site contributors using the pull form.

Going to attach a patch to catch the exception and display a message warning the user instead.

CommentFileSizeAuthor
#2 2908754-2-Handle-missing-files-gracefully.patch1.83 KBDeFr

Comments

DeFr created an issue. See original summary.

DeFr’s picture

DeFr commented
Status: Active » Needs review
StatusFileSize
new 2908754-2-Handle-missing-files-gracefully.patch1.83 KB

  • DeFr authored a04688d on 8.x-1.x 
    Issue #2908754 by DeFr, Grimreaper: Handle missing file in source...
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Needs review » Fixed

Hello,

Thanks for the patch. I have been able to reproduce the bug and it fixes it.

It has now been merged.

I will fix #2905061: Infinite loop when pulling content before creating a new release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.