The current page specific visibility toggle currently operates opposite to its function. This is to say that if you select "all pages except the listed" the widget will be rendered on all pages listed in the text area. Similarly, if you choose only listed pages (text area) it will render on all pages except those listed in the text area.
Based on the screenshot below, let's take into consideration this widget visibility being contrary to the visibility settings.
Current code is:
$page_match = (($page_match or $visibility) && !($page_match and $visibility));
Modify the $page_match conditional statement to correctly determine:
N/A
N/A
N/A
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | snapengage-switch-visibility-text-2908382-11.patch | 1002 bytes | JQTNguyen |
| #7 | visibility-toggle-adjustments-2908382-7.patch | 1016 bytes | laughnan |
| #4 | visibility-toggle-adjustments-2908382-4.patch | 1018 bytes | laughnan |
| Screen Shot 2017-09-12 at 2.06.56 PM.png | 94.67 KB | laughnan |
Comments
Comment #2
laughnanComment #3
laughnanComment #4
laughnanAdding initial patch. Conditionals make my head spin so eyes on this would be great.
Comment #5
laughnanComment #6
laughnanI did test this on 8.x-2.0-alpha1 (which is head for 2.x-dev as well) and it looks like @arnested did something in commit 4c54fe99be97d518aa5cbe36ecfe4a1a3bf26be7, but I don't think this worked.
The conditional patch that I supplied seems to have fixed it, but conditionals make my head hurt so any feedback is welcome.
Comment #7
laughnanAdding a new patch that replaces the
andwith&&for consistency.Comment #9
arnested commentedSorry for the long delay and thank you for your patch!
I have added it and made a new release 8.x-2.0-alpha2.
Comment #11
JQTNguyen commentedWe are currently using the aforementioned 8.x-2.0-alpha2 release where this should have been fixed, and as far as we can tell, this is still an issue (i.e.: in order to get the module working, we selected "Add to the listed pages only.", but left the text area blank).
The logic is still backwards, but it works consistently. Maybe the "fix" here can be just to switch the order that the text labels appear? I've created a patch for 8.x-2.0-alpha2 that does just this.