Closed (duplicate)
Project:
Superfish Dropdown Menu
Version:
8.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
10 Sep 2017 at 08:38 UTC
Updated:
27 Jun 2018 at 01:52 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
darkdimField 'menuActiveTrail' not found in SuperfishBlock
Referenced field is not found in subject class.
Comment #3
caspervoogt commentedSame here. API change to MenuTreeParameters(), maybe. I looked into a bit but was unsure. I did not see references to menuActiveTrail in the MenuTreeParameters() class though. Maybe it got renamed.
Comment #4
darkdimHey.
Thank you, but you're right, here removed the interface, see what can be done
v Drupal 8.4.0-rc1
v 8.3.7
Comment #5
darkdimpatch for the kernel, returns the parameter containing the interface object to the constructor. It is unclear why he did not make it, and there is some other way to get the parameters?!
Comment #6
JvE commentedSee #2856625: Remove unused menu active trail service from SystemMenuBlock
Comment #7
aleksipI think #2856625: Remove unused menu active trail service from SystemMenuBlock is a BC breaking change in a minor core release, and should be reverted. Added a comment about this in that issue.
Edit: apparently it isn't considered a BC breaking change: https://www.drupal.org/core/d8-bc-policy
Comment #8
yasThe patch #5 works as expected in Drupal 8.5.x-dev.
Comment #9
darkdimComment #10
darkdimComment #11
aleksipI don't think this issue should be moved to core. There is already the core issue #2856625: Remove unused menu active trail service from SystemMenuBlock and that core commit could just be reverted, fixing the problem for Superfish and others. It would be basically the same than what the patch in this issue is doing.
However, it doesn't look like #2856625: Remove unused menu active trail service from SystemMenuBlock will be reverted. So the stuff that was taken out of core should be added to Superfish itself. It should be almost as simple as adding the lines removed from the core class to the Superfish class that extends it. I could have a go at it this weekend unless someone beats me to it!
Comment #12
aleksipI managed to get some discussion going on about the core change, and currently it looks like the core commit might be reverted after all, and added in 8.5, giving Superfish and other modules more time for a fix.
Also in the discussion a great way to avoid future breakage came up: #2856625-25: Remove unused menu active trail service from SystemMenuBlock. So this would be a good way to do the fix in Superfish too.
Comment #13
jhuhta commentedMy first attempt to fix this, in a way that was suggested in the core issue by @aleksip and others.
Greetings from Vienna 2017 First-Time Sprinter Workshop.
Comment #14
jhuhta commentedSecond attempt; fixes and cleanup.
Comment #15
jhuhta commentedComment #16
mehrpadin commentedHey everybody,
Thanks for the patch, there appears to be a similar issue and a patch which I've just applied, #2896583: Menu active trail service removed from SystemMenuBlock, please close this as a duplicate, thanks again, much appreciated.
Comment #17
aleksip@mehrpadin I'm not sure if the patch in that issue works in 8.5? I left a comment in that issue.
Comment #18
jhuhta commentedComment #19
bensti commented@ aleksip i try patch #14 with drupal 8.5.3 and it's work! no more error !
Comment #20
aleksip@bensti I believe Superfish 8.x-1.2 contains an alternative fix to this issue, so do try that out.
Comment #21
stephen ollmanGetting the fatal error after upgrading from Core 8.4.4 to 8.5.4.
Applying the Superfish module update 8.x-1.1 to 8.x-1.2 fixed the issue.