Thanks for your work on this!

I think this module could be enhanced with one more permission per content type: Administer own [type] content revisions. That way you can grant a user access to revisions on their own blog posts (for example) without allowing them to administer revisions on all other blog posts.

I'll post a patch in a moment.

CommentFileSizeAuthor
#2 node_revision_per_role-administer_own-2906897-2.patch1.56 KBothermachines

Comments

othermachines created an issue. See original summary.

othermachines’s picture

othermachines commented
Status: Active » Needs review
StatusFileSize
new node_revision_per_role-administer_own-2906897-2.patch1.56 KB

Patch attached for review.

Users with the original administer $type content revisions will always be granted access to all nodes of that type.

If a user does not have that permission, administer own $type content revisions will grant access if they are the node's author.

I have slightly changed the labeling of the permissions so it is consistent with the node module and easier to read. I have not altered the machine name of the original permission, however, so no update is required.

Cheers -

  • takim committed c5188a1 on 7.x-1.x 
    Issue #2906897 by othermachines: New per content type permission for...

takim credited takim.

takim’s picture

takim commented
Status: Needs review » Fixed

Patch has been reviews and tested and it works.

takim’s picture

takim commented

Thanks for contributing.

othermachines’s picture

othermachines commented

You're welcome. Next time if you could attribute the commit to the author of the patch that would be terrific. :)

takim’s picture

takim commented

I did when I made commit.
http://cgit.drupalcode.org/node_revision_per_role/commit/?id=c5188a1

othermachines’s picture

othermachines commented

Thanks for the mention, but you should give author attribution. I see you didn't know that. Here's some helpful info: https://www.drupal.org/node/1146430

Cheers -

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.