The webform random fieldset component works but the fields inside are not randomized. The attached patch addresses this issue. Please review when you get a chance. Limitation: This works on the top level only. In other words, you cannot nest random fieldsets within other random fieldsets. The nested fieldset fields will not be randomized. Also, the attached webform_random_fieldset submodule patch needs committed in the repo.

Comments

uberhacker created an issue. See original summary.

uberhacker’s picture

StatusFileSize
new3.04 KB

Status: Needs review » Needs work

The last submitted patch, 2: webform_random-fieldset-2906065.patch, failed testing. View results

uberhacker’s picture

Issue summary: View changes
StatusFileSize
new5.06 KB
biigniick’s picture

thanks

biigniick’s picture

Status: Needs work » Needs review

the new dev version should have new functionality. give it a look. thanks in advance.

- nick

uberhacker’s picture

StatusFileSize
new10.44 KB

I tested the module and it works great. Both top-level and fieldset-level elements are randomized. Attached is a patch to correct issues with Drupal coding standards and best practices. I fixed some grammar issues as well. You might also consider adding a hook_help function to assist new users with configuration. Some Simpletests wouldn't be a bad idea either. Disregard this patch and use #8 below instead.

uberhacker’s picture

StatusFileSize
new10.42 KB

I removed the pointless db_like function that wasn't working and replaced it with something that actually works when you uninstall the modules.

biigniick’s picture

great work, @uberhacker!

everything looks good to me.

biigniick’s picture

Status: Needs review » Fixed

  • BiigNiick committed 0c61c38 on 7.x-1.x
    Issue #2906065 by uberhacker: Add random fieldset functionality
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.