Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Inside aggregator_save_category()
function db_last_insert_id('aggregator', 'cid')
should be db_last_insert_id('aggregator_category', 'cid')
Comment | File | Size | Author |
---|---|---|---|
#9 | aggregator-save_category-d6.patch | 834 bytes | mustafau |
#4 | test-aggregator-category-menu-link-290561-4.patch | 1.65 KB | mustafau |
#2 | test-aggregator-category-menu-link-290561-2.patch | 1.78 KB | mustafau |
aggregator-save-category.patch | 820 bytes | mustafau | |
Comments
Comment #1
Dries CreditAttribution: Dries commentedGood catch. It would be great if you could look at the aggregator module tests to see why this wasn't identified by the tests. It would be great if you could re-submit this patch with some aggregator test improvements. Thanks.
Comment #2
mustafau CreditAttribution: mustafau commentedDone. First apply attached patch and run "Categorize feed item functionality" test. You will see one fail. Then apply the previous patch and run "Categorize feed item functionality" test again. You will see 0 fails.
Comment #3
Dries CreditAttribution: Dries commentedLooks good. I would merge addCategory with its calling function. Also, the 'return $category;' seems bogus. This would be taken care of if you merged both functions.
Comment #4
mustafau CreditAttribution: mustafau commentedDone.
Comment #5
Dries CreditAttribution: Dries commentedThanks mustafu! Yay for the test improvements. Committed to CVS HEAD.
Comment #6
Anonymous (not verified) CreditAttribution: Anonymous commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #7
mustafau CreditAttribution: mustafau commentedNeeds to be fixed in 6.x too.
Comment #8
AlexisWilke CreditAttribution: AlexisWilke commentedCool to see that there is a fix for this one! I guess it did not make it to 6.10. At times, it just feels like you're way slow guys!
I will mark my own bug #352719: Add Category generates an SQL error (PostgreSQL) report as a duplicate of this bug.
Thank you for providing the fix!
Alexis Wilke
Comment #9
mustafau CreditAttribution: mustafau commentedRerolling for DRUPAL-6.
Comment #10
brianV CreditAttribution: brianV commentedTrivial change, works when I test it, RTBC
Comment #11
Gábor HojtsyGreat, thanks, committed to Drupal 6 too.