Closed (fixed)
Project:
Drupal core
Version:
8.4.x-dev
Component:
rest.module
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
28 Aug 2017 at 19:11 UTC
Updated:
22 Sep 2017 at 23:45 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
tedbowComment #3
tedbowMarking as 'Novice'.
It looks this problem was introduced in #2805281-10: ?_format=hal_json error responses are application/json, yet should be application/hal+json
The previous block was
But then in that issue
static::$expectedErrorMimeTypewas no longer needed. So maybe just replace error.Comment #5
tedbowSetting back to needs review. #2 had a totally unrelated error. Not sure why
Comment #6
wim leersYep, the two branches of that if-test used to be different. As of #2805281: ?_format=hal_json error responses are application/json, yet should be application/hal+json, that bug in D8 has been fixed. But #2805281 forgot to simplify this code accordingly.
Comment #7
dawehnerSimplifying code, works for me :)
Comment #8
wim leers+1.
I stupidly didn't even notice the patch was ready — based on #3 adding that tag, I assumed it needed work :P
Comment #9
tedbow@Wim Leers yep sorry I added the tag because I thought a novice could mark it RTBC.
Comment #10
wim leersAhh! :) Np in any case.
Comment #14
xjmlol nice. Committed and pushed to 8.5.x and backported to 8.4.x as a test code cleanup. Thanks!