Problem/Motivation

We forgot to set the translatable flag, so the data tables are ignored and library items can not be translated.

Proposed resolution

Make the entity type translatable, add update function.

Note that views will be broken without #2904686: ViewsEntitySchemaSubscriber does not update views base table when making an entity type translatable

Remaining tasks

Convert needs to keep translations

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#9 library-items-not-translatable-2904687-9-interdiff.txt14.27 KBberdir
#9 library-items-not-translatable-2904687-9.patch21.83 KBberdir
#9 library-items-not-translatable-2904687-9-test-only.patch5.5 KBberdir
#9 library-items-not-translatable-2904687-9-test-only.patch5.47 KBberdir
#8 library-items-not-translatable-2904687-8-interdiff.txt630 bytesberdir
#8 library-items-not-translatable-2904687-8.patch9.08 KBberdir
#6 library-items-not-translatable-2904687-6-interdiff.txt3.62 KBberdir
#6 library-items-not-translatable-2904687-6.patch9.34 KBberdir
#4 library-items-not-translatable-2904687-3.patch6.62 KBberdir
#2 library-items-not-translatable-2904687-2.patch7.75 KBberdir

Comments

Berdir created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
StatusFileSize
new library-items-not-translatable-2904687-2.patch7.75 KB
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
StatusFileSize
new library-items-not-translatable-2904687-3.patch6.62 KB

the storage class schema is now not requied.

Status: Needs review » Needs work

The last submitted patch, 4: library-items-not-translatable-2904687-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new library-items-not-translatable-2904687-6.patch9.34 KB
new library-items-not-translatable-2904687-6-interdiff.txt3.62 KB

The view isn't converted correctly because somehow the entity type on the label field is missing, no idea why.

Status: Needs review » Needs work

The last submitted patch, 6: library-items-not-translatable-2904687-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new library-items-not-translatable-2904687-8.patch9.08 KB
new library-items-not-translatable-2904687-8-interdiff.txt630 bytes

Ok, so it does want it to be linked, fine test, you win.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
StatusFileSize
new library-items-not-translatable-2904687-9-test-only.patch5.47 KB
new library-items-not-translatable-2904687-9-test-only.patch5.5 KB
new library-items-not-translatable-2904687-9.patch21.83 KB
new library-items-not-translatable-2904687-9-interdiff.txt14.27 KB

So much fun while writing a test.

Lots of changes in the view, due do duplications because of joins, I decided to for now only show the default translation.

This will fail because I first need to fix some related bugs in paragraphs.

The last submitted patch, 9: library-items-not-translatable-2904687-9-test-only.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Status: Needs review » Needs work

The last submitted patch, 9: library-items-not-translatable-2904687-9.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • Berdir committed 2917dfb on 8.x-1.x 
    Issue #2904687 by Berdir: Library items are not translatable
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Fixed

Committed, passed now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.