Due to the unreviewed patch #12 in #2857622: Address required does not respect webform conditionals being immediately committed before review, various issues fixed in previous patches were reintroduced and have made it into a new release.
The address component is therefor again checking the requiredness of components, which obviously should have always been a task of webform and is the same reason why that issue was created in the first place. But that issue is closed and I can't reopen it so this issue is for fixing the issues created in that issue.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | dvg_webform_components-duplicate_errors-2903819-8.patch | 4.03 KB | joshahubbers |
Comments
Comment #2
paulvandenburg commentedThis patch restores previous fixes and a little clean up.
Comment #3
paulvandenburg commentedComment #4
askibinski commentedTested with the usecase in #2857622: Address required does not respect webform conditionals and code also looks good.
Comment #5
ralphvdhoudt commentedPatch doesn't apply anymore to the current dev version. Is it still needed? How can it be reproduced?
Comment #6
joshahubbers commentedThe patch is still needed. "Required" validation should be done by webform, not by this module. Other validations should be ok...
I updated the patch for the current dev version...
Comment #7
joshahubbers commentedComment #8
joshahubbers commentedNew patch, just removes the "required" parameter from the validation functions...
Comment #9
ralphvdhoudt commentedWorks as expected