Problem/Motivation

Followup from #2782891: The Page Title block's title behaves in a confusing way with Settings Tray and the Help block incorrectly has Settings Tray styling. An earlier patch on that issue issue included changes to CSS and JavaScript to make attaching contextual links use more specific selectors; however, those changes appear to be unneeded and out of scope for the current patch. See comments #95 and #97 on this issue.

Proposed resolution

Discuss using the more specific selectors. The attached patch is the earlier changes from the issue.

Remaining tasks

  • Patch no longer applies.
  • Check with Wim Leers about this change and possibly a JS maintainer; there may have been more reasons for it earlier on the issue but it may also be desirable on its own.

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
tray-contextual-css-do-not-test.patch5.42 KBxjm

Comments

xjm created an issue. See original summary.

xjm’s picture

xjm
she/her
Primary language English
commented
Related issues: +#2782891: The Page Title block's title behaves in a confusing way with Settings Tray and the Help block incorrectly has Settings Tray styling

xjm credited Wim Leers.

xjm credited tedbow.

xjm’s picture

xjm
she/her
Primary language English
commented

Crediting Wim (who originally added this change) and Ted (who worked with me to descope it from the other issue).

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Closed (works as designed)

I missed this issue because it wasn't added as a related issue to #2782891.

Per #2782891-111: The Page Title block's title behaves in a confusing way with Settings Tray and the Help block incorrectly has Settings Tray styling, I don't think we need this.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Component: outside_in.module » settings_tray.module

Changing to new settings_tray.module component. @drpal thanks for script help! :)