In https://www.drupal.org/pift-ci-job/742566 we have a test failure at D8.5 which was OK at D8.3

1) Drupal\Tests\rules\Kernel\Engine\AutocompleteTest::testNodeAutocomplete
Failed asserting that Array &0 (
    'value' => 'node.status'
    'label' => 'node.status (Published)'
) is identical to Array &0 (
    'value' => 'node.status'
    'label' => 'node.status (Publishing status)'
).

The text has changed, as we probably need to solve this in a similar way to #2871526: AutocompleteTest fails at D8.4 but OK at D8.3

CommentFileSizeAuthor
#3 2903101-3.rules_autocomplete_nodestatus.patch1.17 KBjonathan1055
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jonathan1055 created an issue. See original summary.

jonathan1055’s picture

jonathan1055 CreditAttribution: jonathan1055 as a volunteer commented
Assigned: Unassigned » jonathan1055
Issue summary: View changes

I need to install 8.5 dev locally to do some testing, then I'll make a patch for this.

It would be really nice if Rules had 'daily testing' turned on so that these issues could be discovered as soon as they happen, and not wait for another issue with a patch to fail first.

jonathan1055’s picture

jonathan1055 CreditAttribution: jonathan1055 as a volunteer commented
Title: AutocompleteTest fails at D8.5 due to changed "publishing" text » AutocompleteTest fails at D8.4 due to changed "publishing" text, OK at D8.3
Issue summary: View changes
Status: Active » Needs review
FileSize
2903101-3.rules_autocomplete_nodestatus.patch1.17 KB

The core change from 'Publishing status' to 'Published' has been made at 8.4 but not 8.3. Here's a patch which fixes the problem, just like in #2871526: AutocompleteTest fails at D8.4 but OK at D8.3

jonathan1055’s picture

jonathan1055 CreditAttribution: jonathan1055 as a volunteer commented

The testing above shows that the patch allows the Rules tests to pass at 8.5, 8.4 and 8.3

The pull request is https://github.com/fago/rules/pull/485

jonathan1055’s picture

jonathan1055 CreditAttribution: jonathan1055 as a volunteer commented

In github the tests pass - https://travis-ci.org/fago/rules/jobs/266780847#L568
However, they reoprt 'failed' which seems to be due to coding standards violations in other files - https://travis-ci.org/fago/rules/jobs/266780847#L1048

So even though build #2310 is being reported as 'failed' it is doing the right things and fixing the tests. Hopefully this can be merged into the real -dev code repository, so that tests start passing again on d.o.

Jonathan

jonathan1055’s picture

jonathan1055 CreditAttribution: jonathan1055 as a volunteer commented

For info, the core commit which scuppered the Rules tests was http://cgit.drupalcode.org/drupal/commit/?id=c53b322 on 15th June, for #2068063: Change "Save and keep un-/published" buttons to a "Published" checkbox and an included "Save" button. The most recent Rules commit was 25th May so that was the last time that the tests were run on d.o. Because that was before the core change, it appears on Rules project testing page that all is OK. But as soon as someone tries to test a patch they get the unrelated failure.

jonathan1055’s picture

jonathan1055 CreditAttribution: jonathan1055 as a volunteer commented

To prove that it is the coding standards violations which is making the github/travis tests fail, I created a branch and removed the calls to phpcs from .travis.yml. The test build for all the environments are now green not red https://travis-ci.org/jonathan1055/rules/builds/266875682

So until we fix every coding violation in Rules we need to work out how make the violations not fail the tests. Or is the plan to fix all the coding standards asap?

fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago at drunomics commented
Status: Needs review » Fixed

Thank you, merged! Let's discuss the coding style issue over at #2903855: Fix coding standards and coding style issues.

jonathan1055’s picture

jonathan1055 CreditAttribution: jonathan1055 as a volunteer commented

Thanks, that's great.

Just for my interest, when you merge in a pull request on github, is there an automatic process to sync the code source on d.o. or do you have to do that manually? The reason I ask is that you have set this issue to fixed but the commit has not showed up in the drupal.org codebase yet.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 for Workday, Inc. commented
Status: Fixed » Reviewed & tested by the community

I don't think this was pushed?

  • jonathan1055 authored 5e454ad on 8.x-3.x 
    Issue #2903101 by jonathan1055: AutocompleteTest fails at D8.4 due to...
fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago at drunomics commented
Status: Reviewed & tested by the community » Fixed

Sry I forgot to update the d.o. mirror - done now!

jonathan1055’s picture

jonathan1055 CreditAttribution: jonathan1055 as a volunteer commented

Thanks fago. It will be good to have tests passing on d.o. now. Then other patches will be able to pass too.

The testbot run https://www.drupal.org/pift-ci-job/770477 is taking ages to start though.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jonathan1055’s picture

jonathan1055 CreditAttribution: jonathan1055 as a volunteer commented
Assigned: jonathan1055 » Unassigned

Removing assigment to me.