Problem/Motivation

Previously sourcemap files were generated alongside transpile JavaScript, *.js.map. Those files are no longer generated and sourcemap data is only appended to the transpiled JavaScript when watching in development mode. When deleting files, the watcher attempts to delete files that are not present.

Proposed resolution

Remove the fs.unlink step for sourcemap files.

CommentFileSizeAuthor
#2 2902417-2.patch509 bytesGrandmaGlassesRopeMan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drpal created an issue. See original summary.

GrandmaGlassesRopeMan’s picture

GrandmaGlassesRopeMan
he/him
Primary language English
Location 🌎
CreditAttribution: GrandmaGlassesRopeMan at Acquia commented
FileSize
2902417-2.patch509 bytes
droplet’s picture

droplet CreditAttribution: droplet commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 2902417-2.patch, failed testing. View results

droplet’s picture

droplet CreditAttribution: droplet commented
Status: Needs work » Reviewed & tested by the community

  • Cottser committed 6eaa470 on 8.5.x 
    Issue #2902417 by drpal: Do not attempt to unlink not present *.js.map...

Cottser credited Cottser.

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr at Northern Commerce commented
Status: Reviewed & tested by the community » Fixed

Makes sense, looks like the *.js.map generation was removed in #2868137: Improve JavaScript build tooling.. Gave this a quick test as well.

Committed 6eaa470 and pushed to 8.5.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.