I am spinning off an issue from

#2862510: Convert system/tests/src/Ajax to JavascriptTestBase

There are just too many intricate design decisions and changes ... for a high quality patch to be produced and reviewed in a bulk conversion issue.

CommentFileSizeAuthor
#3 framework-2902029-3.patch4.32 KBmartin107

Comments

martin107 created an issue. See original summary.

dawehner’s picture

dawehner
Primary language German
commented

+1

martin107’s picture

martin107 commented
Status: Active » Needs review
StatusFileSize
new framework-2902029-3.patch4.32 KB

I am unsure at the moment -- as to which direction to take ....

Ignoring all subtly there are three choices.

Unit /Kernel / Functional

We already have good unit testing in this area... so no need to duplicate .. How should our conversion complement those tests?

It would be a major change to do the end-to-end test and cover the javascript and only testing by pushing buttons and clicking links

So I am just posting a simplistic first cut ... while I take a view about what is appropriate.

Status: Needs review » Needs work

The last submitted patch, 3: framework-2902029-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

droplet’s picture

droplet commented
Related issues: +#1988968: Drupal.ajax does not guarantee that "add new JS file to page" commands have finished before calling said JS

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

martin107’s picture

martin107 commented
Assigned: martin107 » Unassigned

There are a batch of issue underconsideration

#2862510: Convert system/tests/src/Ajax to JavascriptTestBase

I am going to focus my efforts on those issues first.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Needs work » Closed (duplicate)

This was done in #2809533: Convert AJAX part of \Drupal\system\Tests\Ajax\FrameworkTest to JavascriptTestBase, so closing this