Settings tray leaves dashed outline on followup pages

@SKAUGHT nice catch.

I think it even easier to reproduce

1. Turn on Edit Mode on any non-admin page.
2. In address bar or another tab(key is don't turn off edit mode) got any admin page
3. then, new page load under Seven theme. all elements have dashed outline on them.

Pretty sure this caused it #2784853: Determine when Outside In library should be loaded: piggyback on contextual_toolbar() but not sure why it is happening because Seven removes all contextual links so we should not have the behavior.

Ok this is caused by changes from #2784853: Determine when Outside In library should be loaded: piggyback on contextual_toolbar().
That issue simplified the module by always attaching the outside_in library if the contextual item was in the toolbar.

Then we just check localStorage.getItem('Drupal.contextualToolbar.isViewing') === 'false'
Which will be true if you are in edit mode regardless of whether there any actually contextual links on the page.

So this patch changes to only do this check when the first Contextual link is added to the page.

+++ b/core/modules/outside_in/tests/src/FunctionalJavascript/OutsideInBlockFormTest.php
@@ -238,6 +238,9 @@ protected function openBlockForm($block_selector, $contextual_link_container = '
+    // When page first loads Edit Mode is not triggger until first contextual

s/triggger/triggered/

Fixed on commit, interdiff attached.

Committed and pushed c67c0e302c to 8.5.x and 98f51ad5f1 to 8.4.x. Thanks!

I've reported this bug several times, glad to see it fixed!

Changing to new settings_tray.module component. @drpal thanks for script help! :)