When the function generateUniqueUsername is called start to test from the number 2, why?
Example:
For the name Jane:
Iteration # 1: Jane 2
Iteration # 2: Jane 3
Iteration # 3: Jane 4
....

Why do you start from 2?

The patch is for start from 1.

CommentFileSizeAuthor
start-from-one.patch637 bytesrpayanm

Comments

rpayanm created an issue. See original summary.

gvso’s picture

gvso
Primary language Spanish
commented
Title: generateUniqueUsername can start from 1 » Start generateUniqueUsername from 1

Thanks @rpayanm! I'll review this tonight

We might also need to update 8.x-2.x branch

gvso’s picture

gvso
Primary language Spanish
commented
Title: Start generateUniqueUsername from 1 » Start generateUniqueUsername at 1

  • gvso committed c2b6a33 on 8.x-1.x 
    Issue #2901117 by rpayanm: Start generateUniqueUsername at 1
gvso’s picture

gvso
Primary language Spanish
commented
Version: 8.x-1.x-dev » 8.x-2.x-dev

  • gvso committed a9ce4b0 on 8.x-2.x 
    Issue #2901117 by rpayanm: Start generateUniqueUsername at 1
gvso’s picture

gvso
Primary language Spanish
commented
Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.