Problem/Motivation

When #2787881: Moderating a non-translatable entity type throws exception was committed, we had to use the 'entity_test_with_bundle' entity type because Content Moderation did not work with entity types with non-config bundles.

That's no longer the case since #2799785: Entity types with non-config bundles can not be moderated.

Proposed resolution

Clean up the test code that was added in #2787881: Moderating a non-translatable entity type throws exception.

Remaining tasks

Review.

User interface changes

Nope.

API changes

Nope.

Data model changes

Nope.

CommentFileSizeAuthor
#13 2898020-13.patch8.73 KBamateescu
#11 2898020-11.patch8.81 KBtimmillwood
#6 interdiff.txt1.21 KBamateescu
#6 2898020-6.patch8.8 KBamateescu
#2 2898020.patch8.3 KBamateescu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amateescu created an issue. See original summary.

amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
Status: Active » Needs review
FileSize
2898020.patch8.3 KB

This should make those two test cases much easier to read.

Status: Needs review » Needs work

The last submitted patch, 2: 2898020.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
Status: Needs work » Needs review

That was a HEAD fail from #2894499-17: Rename 'Editorial workflow' to 'Editorial'.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Status: Needs review » Reviewed & tested by the community

Nice clean up!

amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
FileSize
2898020-6.patch8.8 KB
interdiff.txt1.21 KB

Missed a couple of spots.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 6: 2898020-6.patch, failed testing. View results

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Status: Needs work » Reviewed & tested by the community

Unrelated test fail, back to RTBC.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Reviewed & tested by the community » Needs work

It needs a reroll; I guess the issue migration prevented it from being marked "Needs work".

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Status: Needs work » Reviewed & tested by the community
FileSize
2898020-11.patch8.81 KB

Here's the reroll @xjm, so going straight back to RTBC.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 11: 2898020-11.patch, failed testing. View results

amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
Status: Needs work » Reviewed & tested by the community
FileSize
2898020-13.patch8.73 KB

YARR! (yet another reroll :D)

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 8.5.x-dev » 8.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.5.x and cherry-picked to 8.4.x. Thanks!

  • catch committed e259a77 on 8.5.x 
    Issue #2898020 by amateescu, timmillwood: Simplify...

  • catch committed ecfd3f8 on 8.4.x 
    Issue #2898020 by amateescu, timmillwood: Simplify...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.