Hi @lingros,
here is an issue with the patch that checks the entered values are valid on admin form.
As i've discovered checking gmap key is valid or not needs external library or maybe a curl call, but i think from a validate function it could be a bit too much - but feel free to implement it if you know a better way :)
Bests,
Balazs.

CommentFileSizeAuthor
#2 implement-form-validations-2897144-2.patch2.14 KBtatarbj

Comments

tatarbj created an issue. See original summary.

tatarbj’s picture

tatarbj
Primary language Hungarian
Location Brussels
commented
StatusFileSize
new implement-form-validations-2897144-2.patch2.14 KB

  • lingros committed e478080 on 7.x-1.x 
    Issue #2897144 by tatarbj: Implement form element validations for the...
lingros’s picture

lingros commented
Status: Needs review » Fixed

Hi @tatarbj,
thank you for the idea and for the patch. I've used it, but I've done some modifications such as extra validation for stroke weight (you used integer validation, but I think it's inappropriate here, weight can be decimal number and shouldn't be negative), additional check for stroke color and so on.
Checking gmap key isn't probably possible, at least not simply. I've found some discussions about it (e.g. https://stackoverflow.com/questions/4428915/how-do-i-catch-an-invalid-ap... and https://groups.google.com/forum/#!msg/Google-Maps-API/oHfKEazKd0M/9yqQh8...). So I suggest not to solve it, if you enter invalid, gmap just won't render and in JS console you can read more informations about an error.

tatarbj’s picture

tatarbj
Primary language Hungarian
Location Brussels
commented

Great collaboration it was then :)

lingros’s picture

lingros commented
Status: Fixed » Closed (fixed)