This:
public function preSaveRevision(EntityStorageInterface $storage, \stdClass $record) {
parent::preSaveRevision($storage, $record);
…
if ($is_new_revision) {
$record->revision_created = self::getRequestTime();
}
}
… causes the Media entity type's revision timestamp to behave differently compared to all other entity types. Discovered while working on #2835767-45: Media + REST: comprehensive test coverage for Media + MediaType entity types.
i.e. it causes the value set by setRevisionCreationTime() to be overwritten.
Either do the same as Node, or update Node to the same as Media.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 2897026-4.patch | 4.03 KB | seanb |
| #6 | 2897026-6.patch | 4.03 KB | seanb |
| #6 | interdiff-4-6.txt | 510 bytes | seanb |
Comments
Comment #2
wim leersComment #3
seanbJust looked into this. This was changed in #2831274-59: Bring Media entity module to core as Media module to address the comment in 54.2. It looks like
setRevisionCreationTime()is only called inContentEntityForm.Not exactly sure what the best way is to fix this. For media revisions created through the form the revision timestamp is changed as it should in
ContentEntityForm. For new media the revision_created value is added by the default value of thecreatedfield type. When creating new revisions for existing media through code though, the revision timestamp never seems to be updated. It looks like this is also an issue for nodes.I guess the solution would be to stop setting the revision timestamp in
ContentEntityFormand always callsetRevisionCreationTime()inpreSaveRevision(). I don't think developers should need to set the revision timestamp. So in this case add the changes in media to node and block content as well.Comment #4
seanbLet's see what the testbot thinks of this.
Comment #6
seanbNow with the correct column name for nodes..
Comment #8
berdirMaybe we can also merge this into #2869056: Automatically set revision user/log information/created time on entity revisions?
Comment #9
wim leers+1!
Comment #11
vijaycs85Some of the changes here are already in media and moved some of them to #2869056: Automatically set revision user/log information/created time on entity revisions
Comment #12
seanb