Problem/Motivation

This is a bug report but I'm filing it against 8.4.x because it's not horribly urgent.

Drupal\Tests\Component\EventDispatcher\ContainerAwareEventDispatcherTest looks like this:

[..]
use Symfony\Component\EventDispatcher\Tests\ContainerAwareEventDispatcherTest as SymfonyContainerAwareEventDispatcherTest;
use Symfony\Component\EventDispatcher\Tests\TestEventListener;

/**
 * Unit tests for the ContainerAwareEventDispatcher.
 *
 * NOTE: 98% of this code is a literal copy of Symfony's emerging
 * CompiledEventDispatcherTest.
 *
 * This file does NOT follow Drupal coding standards, so as to simplify future
 * synchronizations.
 *
 * @see https://github.com/symfony/symfony/pull/12521
 *
 * @group EventDispatcher
 */
class ContainerAwareEventDispatcherTest extends SymfonyContainerAwareEventDispatcherTest

If we click through to that pull request: https://github.com/symfony/symfony/pull/12521 we see that it's been closed.

We should not depend on a test from a dependency, because it could move or change expectations.

A comment in #2874909-25: Update Symfony components to 3.3.* references this test.

Proposed resolution

Figure out what to do.

Remaining tasks

User interface changes

API changes

Data model changes

Comments

Mile23 created an issue. See original summary.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

andypost’s picture

andypost’s picture

Category: Bug report » Task

I don't think it's a bug, the \Drupal\Tests\Component\EventDispatcher\ContainerAwareEventDispatcherTest tests exactly core expectations from event listener.
That looks too much binded but let's first resolve #2909185: Deprecate ContainerAwareEventDispatcher in favor of SymfonyEventDispatcher

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.