Once #2895166: Add elements to show datetime and date using jQuery calendars popup is complete, we need widgets to actually show the popup element.

CommentFileSizeAuthor
#2 2895167-2.patch8.09 KBhussainweb

Comments

hussainweb created an issue. See original summary.

hussainweb’s picture

Status: Active » Needs review
StatusFileSize
new8.09 KB

Initial patch with the popup widget. The popup calendar works but the date is not stored correctly.

anas_maw’s picture

Should we create 2 more widget for taarikh_date element?

hussainweb’s picture

@Anas_maw, I have one more widget planned (already in the patch) for a simple select list. Which other widget would you need?

anas_maw’s picture

@hussainweb in src/element there is to type of form element taarikh_date and taarikh_datetime
That what i mean.

hussainweb’s picture

Ah, so if you edit the field settings of a regular datetime field and set it to store Date only, only Date will be shown. Technically, taarikh_datetime is still used but it will just contain a taarikh_date directly, and time won't be shown. This is already working.

anas_maw’s picture

Then we should remove taarikh_date form element, no need for it.

hussainweb’s picture

It actually mirrors the current datetime and date form elements in the core. I think it is helpful to keep it to keep the API parity between core and this module. This way, we will also be able to reuse from core as much as possible.

  • hussainweb committed 95f01a5 on 8.x-1.x
    Issue #2895167 by hussainweb: Add jQuery calendar popup widget
    
hussainweb’s picture

Status: Needs review » Fixed

Pushed changes for the default widget

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.