Move media module out of Core (Experimental) package and into the Core package, but mark it hidden

Yay! For now this would be postponed on steps in https://www.drupal.org/node/2825215#followup-roadmap (first list), right?

As discussed in #2825215-98: Media initiative: Roadmap, the committers have agreed that this is unblocked now and can be unpostponed! The product, framework, and release management teams agreed this on Thursday and it will just need Dries' signoff.

Ah there is a patch already, so setting back to NR. Thanks!

Given that we have a patch and all we need is Dries signoff, is this the right status?

Here's the updated patch. The tests failed b/c the module is hidden in UI for now.

//Naveen

Back to RTBC per #7 as this needs sign off from Dries

+++ b/core/modules/media/tests/src/Functional/MediaInstallTest.php
@@ -28,15 +28,10 @@ protected function setUp() {
     $this->assertSession()->pageTextNotContains('could not be moved/copied because a file by that name already exists in the destination directory');

This test only makes sense when we install using the UI. Now that the module is hidden, maybe we should remove it altogether? (Perhaps with a @TODO to bring it back when the module is exposed again)

Users in contrib will still enable the module in the UI indirectly, through one that depends on it. We can replicate that quite easily by adding a test module that depends on media and enable that.

True! It turns out we already have test modules we can use for that, thanks!

Setting it back to needs review to have another opinion before RTBC.

Thanks! This accommodates #12

+1 from me. Love the progress!

As of #2835767-41: Media + REST: comprehensive test coverage for Media + MediaType entity types: +1!

I like #13; it tests the way users will actually install the module.

Can we file a followup issue to change this test once Media is shown in the UI and link it in the codebase?

Here's the follow-up #2897028: Update the tests once the media module will show in UI and updated the patch accordingly. Back to RTBC

Thanks @naveenvalecha!

I tweaked this slightly on commit since the @todo didn't quite match the standard formatting from them. Here's the diff on commit vs. #13 (which I used instead of #18 to avoid rewrapping lines on commit):

     // Install the media module again, through a test module that depends on it.
     // Note: We use a test module because in 8.4 the media module is hidden.
-    // Once it gets exposed again, this can be simplified.
+    // @todo Simplify this in https://www.drupal.org/node/2897028 once it's
+    //   shown again.

Congratulations everyone!

Awesome thanks @xjm