Placeholder settings field not going throw t() function. this make place holder not localized.

CommentFileSizeAuthor
#2 mobile_number_placeholder-2894142-2.patch703 bytesanas_maw

Comments

Anas_maw created an issue. See original summary.

anas_maw’s picture

anas_maw commented
StatusFileSize
new mobile_number_placeholder-2894142-2.patch703 bytes

This patch make placeholder translatable

anas_maw’s picture

anas_maw commented
Status: Active » Needs review

  • nyariv committed 11aac64 on 8.x-1.x authored by Anas_maw 
    Issue #2894142 by Anas_maw: Mobile number Field placeholder not...
nyariv’s picture

nyariv commented
Status: Needs review » Fixed

Thanks! Patch committed.

anas_maw’s picture

anas_maw commented

Thank you @nyariv.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

nikunjkotecha’s picture

nikunjkotecha
he/him
Primary language Gujarati
Location India, Gujarat, Rajkot
commented

Ideally we should never pass variables into t(). This should be done using config translation and I think it is there by default. @nyariv I request to revert this change back.