Problem/Motivation

If you go to see the comment.schema.yml file you'll see this at the end:

    form_location:
      type: boolean
      label: ' Allow comment title'
    preview:
      type: integer
      label: 'Preview comment'

The form_location label have one additional space in the begining:

label: ' Allow comment title'

Proposed resolution

Delete the additional space

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#6 drupal-additional_space_schema_label-2894014-6-D8.patch1.18 KBadriancid
#3 drupal-additional_space_schema_label-2894014-3-D8.patch531 bytesadriancid

Issue fork drupal-2894014

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

adriancid created an issue. See original summary.

adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented
Issue summary: View changes
adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented
Status: Active » Needs review
StatusFileSize
new drupal-additional_space_schema_label-2894014-3-D8.patch531 bytes
naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Needs review » Reviewed & tested by the community

Thanks!

star-szr’s picture

star-szr
he/him
Primary language English
commented
Component: comment.module » other
Status: Reviewed & tested by the community » Needs work
Issue tags: +String change

While we're fixing this, I think we might as well fix this other instance I found of extra whitespace in config (https://www.drupal.org/core/scope#incomplete):

core/modules/block_content/config/optional/views.view.block_content.yml:
content: 'There are no custom blocks available. '

I think these string changes will require translations to be updated (excerpt from drupal-8.3.5.es.po via https://localize.drupal.org/translate/languages/es):

msgid " Allow comment title"
msgstr " Permitir título de comentario"
adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented
Status: Needs work » Needs review
StatusFileSize
new drupal-additional_space_schema_label-2894014-6-D8.patch1.18 KB

Thanks @Cottser here is the new patch

Status: Needs review » Needs work

The last submitted patch, 6: drupal-additional_space_schema_label-2894014-6-D8.patch, failed testing. View results

star-szr’s picture

star-szr
he/him
Primary language English
commented

HEAD is failing intermittently at the moment, so that test failure is unrelated.

adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented
Status: Needs work » Needs review

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

venkatesh rajan.j’s picture

venkatesh rajan.j commented
Assigned: Unassigned » venkatesh rajan.j
venkatesh rajan.j’s picture

venkatesh rajan.j commented
Assigned: venkatesh rajan.j » Unassigned
Status: Needs review » Reviewed & tested by the community

#6 worked for me.

Unwanted spaces are removed on both block_content and comment.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed 6f6abec and pushed to 8.5.x. Thanks!

  • catch committed 6f6abec on 8.5.x 
    Issue #2894014 by adriancid, Cottser: Additional space in a field...
venkatesh rajan.j’s picture

venkatesh rajan.j commented

Hello catch,

I think you missed to give credit to me :)

venkatesh rajan.j’s picture

venkatesh rajan.j commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

meeni_dhobale made their first commit to this issue’s fork.