As the core entity query QueryFactory is deprecated now, Please replace it with \Drupal\Core\Entity\EntityStorageInterface::getQuery()

CommentFileSizeAuthor
#6 context_fix_deprecated_methods_2893742_6.patch4.95 KBnkoporec
#6 context_deprecated_methods_interdiff_4-6.txt502 bytesnkoporec
#4 context_fix_deprecated_methods.patch4.23 KBnkoporec
#2 removed_deprecated-2893742-1.patch2.48 KBbapi_22

Comments

bapi_22 created an issue. See original summary.

bapi_22’s picture

bapi_22 commented
StatusFileSize
new removed_deprecated-2893742-1.patch2.48 KB
nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Version: 8.x-1.x-dev » 8.x-4.x-dev
nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Status: Active » Needs review
StatusFileSize
new context_fix_deprecated_methods.patch4.23 KB

Hey @bapi_22, I tested your patch and it's not working.Drupal site breaks when applying this patch.I checked and fix the errors from your patch, so please reviewed it.

icurk’s picture

icurk commented
Status: Needs review » Needs work

Replace array() with [] inside ContextManager service to unified coding standard, otherwise nice patch.

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Status: Needs work » Needs review
StatusFileSize
new context_deprecated_methods_interdiff_4-6.txt502 bytes
new context_fix_deprecated_methods_2893742_6.patch4.95 KB

Thanks for the review, created a new patch with proposed fixes.

icurk’s picture

icurk commented
Status: Needs review » Reviewed & tested by the community

  • boshtian committed fda16e0 on 8.x-4.x authored by nkoporec 
    Issue #2893742 by nkoporec, bapi_22: Removed deprecated method/Class...
boshtian’s picture

boshtian commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.