Problem/Motivation

The label "add to library" proposes like something is added, in addition to the current situation.

The action is a conversion / move+link operation though.
Also it conflicts with other likely "Add xyz" operations that could be registered.

Proposed resolution

Rename to "Promote to Library".

Remaining tasks


Find a label to keep.
"Convert to library"
"Move to library"
Note that the term "library" isn't visible until now. The library is just accessed with "Paragraphs" tab in admin/content.
So we could use synonyms such as transform, switch, mutate, turn, alter, modify, change.
Or simply something like "Make reusable".

Call for native language and UX experts... ;-)

User interface changes

Comments

miro_dietiker created an issue. See original summary.

miro_dietiker’s picture

Indeed we are using in our projects "Convert to" for other transformations of Paragraph types.
And this is a similar transformation, just to a special library type.
The only problem is, this is way too long IMHO: "Convert to library item"
File/Send/Post to library?

toncic’s picture

Assigned: Unassigned » toncic
Status: Active » Needs review
StatusFileSize
new7.4 KB

Renamed 'Add to library' to 'Move to library'.
From my point of view we can keep this name.
Let's see what other will say.

miro_dietiker’s picture

The thing is that "move" means commonly move away, so it disappears in the origin.
The term should not only indicate that it is moved, but also linked.

miro_dietiker’s picture

Although in the inverse direction we renamed it to "Unlink from library" and that is not only an unlink operation, but also clones back.

Status: Needs review » Needs work

The last submitted patch, 3: rename_add_to_library_2893492-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

toncic’s picture

Status: Needs work » Needs review

Hmm, 'Send to library' is also acceptable.

miro_dietiker’s picture

Assigned: toncic » miro_dietiker

I'll review the resulting UX and terminology in a complex scenario and report back about the naming decision.

berdir’s picture

Project: Paragraphs Collection » Paragraphs
Component: Library » Module: Library

Moving to Paragraphs project.

miro_dietiker’s picture

Issue summary: View changes
Status: Needs review » Needs work

The best wording i found was "Promote to Library".

It is promoted for reuse. While the representation in the UI changes, it looks still the same in the output.
We decided to

  • use the term "Convert to xyz" to convert between Paragraph types without other side effects.
  • use the term "Add to" if the action adds a new item

I think we should do it like it's defined now.

Outlook: At some later stage, we could add a single "Convert..." action that then provides a conversion wizard that allows to choose if the conversion is into a library item, a different Paragraph type, or other fancy things... At that point "Convert" seems like a good name for all such actions.

miro_dietiker’s picture

Title: Rename "add to library" » Rename "add to library" to "Promote to Library"

Yes, the module name is Paragraph Library, so i think it should be capital "to Library".

miro_dietiker’s picture

Issue tags: +Needs usability review

For consistency, it seem we are lowercase on other locations as well with "library", so we should discuss this and change it consistently.

For instance the paragraph type name is "From library".

Opinions about case?

miro_dietiker’s picture

Adding related Paragraph that cares about the item sequence.

toncic’s picture

Status: Needs work » Needs review
StatusFileSize
new7.71 KB

Renamed 'Add to Library' to 'Promote to Library'.
Updated tests.

Status: Needs review » Needs work

The last submitted patch, 14: rename_add_to_library-14.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

toncic’s picture

Status: Needs work » Needs review
StatusFileSize
new819 bytes
new7.71 KB

This should be better.

The last submitted patch, 14: rename_add_to_library-14.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • miro_dietiker committed c7d8efc on 8.x-1.x authored by toncic
    Issue #2893492 by toncic, miro_dietiker: Rename "add to library" to "...
miro_dietiker’s picture

Status: Needs review » Fixed
Issue tags: -Needs usability review

Committed, thank you.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.