Closed (fixed)
Project:
Drupal core
Version:
8.5.x-dev
Component:
migration system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
7 Jul 2017 at 16:09 UTC
Updated:
23 Sep 2017 at 15:38 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
maxocub commentedHere's a first patch.
Comment #3
phenaproximaSelf-assigning for review.
Comment #4
maxocub commentedI created a dedicated (empty) D7 plugin because this type_map is what I found in the d7_field migration template static_map and it's different from the D6 DateField plugin type_map:
Maybe we want the same thing as D6 since the difference is in the destination field type, not in the source. But then we would have to fix some tests that will fail because datetime is expected instead of timestamp.
Comment #5
heddnAssigning to myself for review this week.
Comment #6
heddnI'm in favor of fixing the test. And make this a general solution for d6/d7.
Comment #7
maxocub commentedHere's a new patch using the same plugin as D6 and with the tests updated.
Should we move the DateField plugin out of the d6 namespace now that it's used for D7 too?
Comment #8
maxocub commentedUpdated IS & title.
Comment #9
quietone commentedYes, thanks.
Comment #10
maxocub commentedI copied the DateField class out of the d6 namespace and deprecated the old class.
Same for the Unit test.
Comment #11
heddnI'm going to assume this comes back green. All the changes in #6 / #9 are now addressed.
Comment #13
catchCommitted/pushed to 8.5.x and cherry-picked to 8.4.x. Thanks!
Comment #16
maxocub commentedComment #18
maxocub commentedComment #19
maxocub commentedComment #20
maxocub commented