Hi all!
I suggest to implement a hook before call a hook_domain_bootstrap_lookup in the module.
Hook name, for example hook_country_path_domain_bootstrap_lookup().

By this hook we can modify received domain before domain lookup process.

CommentFileSizeAuthor
#9 country_path-documentation_for_hook-2890720-9-D7.patch798 bytestibezh
#2 country_path-implement_hook-2890720-1-D7.patch674 bytestibezh

Comments

tibezh created an issue. See original summary.

tibezh’s picture

tibezh commented
Status: Active » Needs review
StatusFileSize
new country_path-implement_hook-2890720-1-D7.patch674 bytes

Patch attached.

itsekhmistro’s picture

itsekhmistro commented

Could you provide one or two example use cases when it can help?

tibezh’s picture

tibezh commented

Hi @itsekhmistro, thnx for your question.

This is hook helped me for setup site on Acquia between environment (dev, stage).
For example, we have a www.sitename.com domain, and for stage environment need open site with a www.sitename-stage.com domain address.
Via hook_country_path_domain_bootstrap_lookup we can override base domain, and we can setup functionality for open www.sitename.com domain when we have a www.sitename-stage.com domain.

itsekhmistro’s picture

itsekhmistro commented

The reasoning sounds good to me.

itsekhmistro’s picture

itsekhmistro commented

The proposed patch is applied to the DEV (7.x-1.x) branch.
And will be included in the next release.

@tibezh Thank you for your work!

itsekhmistro’s picture

itsekhmistro commented
Status: Needs review » Needs work

@tibezh Could you also add the hook definition into country_path.api.inc ?

tibezh’s picture

tibezh commented
StatusFileSize
new country_path-documentation_for_hook-2890720-9-D7.patch798 bytes

Sorry for delay.
Documentation for a new hook is ready, patch attached.

tibezh’s picture

tibezh commented
Status: Needs work » Needs review

  • kashandarash committed d2b70d6 on 7.x-1.x 
    Issue #2890720 by tibezh: applied patch for api file.
kashandarash’s picture

kashandarash commented
Status: Needs review » Fixed

Patch is applied to the DEV branch.
@tibezh Thank you!

tibezh’s picture

tibezh commented
Status: Fixed » Needs review

@kashandarash, You forgot set commit author of the patch. Please, read this article https://www.drupal.org/node/1146430 and rework a commit.
Tell me if you need a help with this.

  • kashandarash committed 0336100 on 7.x-1.x 
    Revert "Issue #2890720 by tibezh: applied patch for api file."

Wrong...
  • kashandarash committed 04ba578 on 7.x-1.x authored by tibezh
    Issue #2890720 by tibezh: applied patch for api file.
kashandarash’s picture

kashandarash commented
Status: Needs review » Fixed

@tibezh, sorry for that, added new commit with right author

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.