$remove_role_plugin = new AddRoleUser($config, 'user_add_role_action', ['type' => 'user'], $this->userRoleEntityType);

$remove_role_plugin->execute($this->account);

I guess it was borrowed from RemoveRoleUserTest class.

CommentFileSizeAuthor
#9 rename-plugin-variable-in-addroleusertest-class-2889433-9.patch1.31 KBpk188
#3 rename-plugin-variable-in-addroleusertest-class-2889433.patch1.46 KBpramodga

Comments

Chi created an issue. See original summary.

pramodga’s picture

pramodga commented
Assigned: Unassigned » pramodga
pramodga’s picture

pramodga commented
Status: Active » Needs review
StatusFileSize
new rename-plugin-variable-in-addroleusertest-class-2889433.patch1.46 KB

Hello Chi,

I've rename the variable names to avoid the ambiguity.

pramodga’s picture

pramodga commented
Assigned: pramodga » Unassigned
chi’s picture

chi commented
Status: Needs review » Reviewed & tested by the community

Thanks.

naveenvalecha’s picture

naveenvalecha
He/Him
commented

LGTM

Thanks!

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/modules/user/tests/src/Unit/Plugin/Action/AddRoleUserTest.php
@@ -41,9 +41,9 @@ public function testExecuteAddNonExistingRole() {
-    $remove_role_plugin = new AddRoleUser($config, 'user_remove_role_action', ['type' => 'user'], $this->userRoleEntityType);
+    $add_role_plugin = new AddRoleUser($config, 'user_remove_role_action', ['type' => 'user'], $this->userRoleEntityType);

Hum, why is this instantiated from the remove role action plugin but still with the add role class? That sounds contradictory.

chi’s picture

chi commented

Most likely that code was copied from RemoveRoleUserTest as is. I suppose it works because second constructor parameter (plugin ID) is not used in this case. However it certainly needs to be changed to user_add_role_action.

pk188’s picture

pk188 commented
Status: Needs work » Needs review
StatusFileSize
new rename-plugin-variable-in-addroleusertest-class-2889433-9.patch1.31 KB

Updated according to #8.

chi’s picture

chi commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Rename plugin variable in AddRoleUserTest class » Fix incorrect plugin variable names in AddRoleUserTest

  • Gábor Hojtsy committed 875c2e5 on 8.3.x 
    Issue #2889433 by pramodga, pk188, Chi: Fix incorrect plugin variable...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Looks better, thanks. Committed.

  • Gábor Hojtsy committed cf07252 on 8.4.x 
    Issue #2889433 by pramodga, pk188, Chi: Fix incorrect plugin variable...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Version: 8.4.x-dev » 8.3.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.